Skip to content

Commit

Permalink
Merge branch 'develop' into release-notes-1.10.5
Browse files Browse the repository at this point in the history
  • Loading branch information
ygit authored Jul 23, 2024
2 parents 004daeb + 130fde4 commit 5530564
Show file tree
Hide file tree
Showing 6 changed files with 28 additions and 17 deletions.
13 changes: 12 additions & 1 deletion packages/hms_room_kit/lib/src/meeting/meeting_store.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2511,11 +2511,22 @@ class MeetingStore extends ChangeNotifier
void checkNoiseCancellationAvailability() async {
isNoiseCancellationAvailable =
await _hmsSDKInteractor.isNoiseCancellationAvailable();

///Here we check if noise cancellation is available, if its available
///then we check if its enabled from dashboard in the default configuration
///If yes we enable it.
///Else we check the noise cancellation status to update the UI
if (isNoiseCancellationAvailable) {
isNoiseCancellationEnabled =
await _hmsSDKInteractor.isNoiseCancellationEnabled();
if ((HMSRoomLayout.roleLayoutData?.screens?.conferencing?.defaultConf
?.elements?.noiseCancellation?.enabledByDefault ??
false) &&
!isNoiseCancellationEnabled) {
_hmsSDKInteractor.enableNoiseCancellation();
isNoiseCancellationEnabled = true;
}
}
notifyListeners();
}

void toggleWhiteboard() async {
Expand Down
4 changes: 2 additions & 2 deletions packages/hmssdk_flutter/example/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ android {
applicationId "live.hms.flutter"
minSdkVersion 21
targetSdkVersion 34
versionCode 511
versionName "1.5.211"
versionCode 514
versionName "1.5.214"
}

signingConfigs {
Expand Down
20 changes: 10 additions & 10 deletions packages/hmssdk_flutter/example/ios/Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,19 @@ GEM
artifactory (3.0.17)
atomos (0.1.3)
aws-eventstream (1.3.0)
aws-partitions (1.949.0)
aws-sdk-core (3.200.0)
aws-partitions (1.955.0)
aws-sdk-core (3.201.1)
aws-eventstream (~> 1, >= 1.3.0)
aws-partitions (~> 1, >= 1.651.0)
aws-sigv4 (~> 1.8)
jmespath (~> 1, >= 1.6.1)
aws-sdk-kms (1.87.0)
aws-sdk-core (~> 3, >= 3.199.0)
aws-sigv4 (~> 1.1)
aws-sdk-s3 (1.155.0)
aws-sdk-core (~> 3, >= 3.199.0)
aws-sdk-kms (1.88.0)
aws-sdk-core (~> 3, >= 3.201.0)
aws-sigv4 (~> 1.5)
aws-sdk-s3 (1.156.0)
aws-sdk-core (~> 3, >= 3.201.0)
aws-sdk-kms (~> 1)
aws-sigv4 (~> 1.8)
aws-sigv4 (~> 1.5)
aws-sigv4 (1.8.0)
aws-eventstream (~> 1, >= 1.0.2)
babosa (1.0.4)
Expand All @@ -44,7 +44,7 @@ GEM
domain_name (0.6.20240107)
dotenv (2.8.1)
emoji_regex (3.2.3)
excon (0.110.0)
excon (0.111.0)
faraday (1.10.3)
faraday-em_http (~> 1.0)
faraday-em_synchrony (~> 1.0)
Expand Down Expand Up @@ -170,7 +170,7 @@ GEM
json (2.7.2)
jwt (2.8.2)
base64
mini_magick (4.13.1)
mini_magick (4.13.2)
mini_mime (1.1.5)
minitest (5.22.3)
multi_json (1.15.0)
Expand Down
4 changes: 2 additions & 2 deletions packages/hmssdk_flutter/example/ios/Runner/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleShortVersionString</key>
<string>1.5.211</string>
<string>1.5.214</string>
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleURLTypes</key>
Expand All @@ -48,7 +48,7 @@
</dict>
</array>
<key>CFBundleVersion</key>
<string>511</string>
<string>514</string>
<key>ITSAppUsesNonExemptEncryption</key>
<false/>
<key>LSApplicationCategoryType</key>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class HMSNoiseCancellationController {
static func createPlugin() {
noiseCancellationController = {
if let pathForNCModel = HMSNoiseCancellationModels.path(for: .smallFullBand) {
return HMSNoiseCancellationPlugin(modelPath: pathForNCModel, initialState: .enabled)
return HMSNoiseCancellationPlugin(modelPath: pathForNCModel, initialState: .disabled)
} else {
assertionFailure("Noise cancellation model was not found")
}
Expand Down
2 changes: 1 addition & 1 deletion packages/hmssdk_flutter/lib/assets/sdk-versions.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
"iOSBroadcastExtension": "0.0.9",
"iOSHLSPlayerSDK": "0.0.2",
"iOSNoiseCancellationModels": "1.0.0",
"android": "2.9.62"
"android": "2.9.64"
}

0 comments on commit 5530564

Please sign in to comment.