Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flut 152/handle logourl error #1636

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Flut 152/handle logourl error #1636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1a4a33
Added error builder in case logo url returns error
Decoder07 Nov 8, 2023
ff34c9b
Lint fixes
Decoder07 Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/hms_room_kit/lib/src/hls_viewer/hls_viewer_header.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
///Dart imports
import 'dart:developer';
import 'dart:io';

import 'package:flutter/material.dart';
Expand Down Expand Up @@ -44,6 +45,13 @@ class HLSViewerHeader extends StatelessWidget {
HMSRoomLayout.roleLayoutData!.logo!.url!)
: Image.network(
HMSRoomLayout.roleLayoutData!.logo!.url!,
errorBuilder: (context, exception, _) {
log('Error is $exception');
return const SizedBox(
width: 30,
height: 30,
);
},
height: 30,
width: 30,
),
Expand Down
8 changes: 8 additions & 0 deletions packages/hms_room_kit/lib/src/meeting/meeting_header.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
///Dart imports
import 'dart:developer';
import 'dart:io';

///Package imports
Expand Down Expand Up @@ -60,6 +61,13 @@ class _MeetingHeaderState extends State<MeetingHeader> {
)
: Image.network(
HMSRoomLayout.roleLayoutData!.logo!.url!,
errorBuilder: (context, exception, _) {
log('Error is $exception');
return const SizedBox(
width: 30,
height: 30,
);
},
height: 30,
width: 30,
),
Expand Down
8 changes: 8 additions & 0 deletions packages/hms_room_kit/lib/src/preview/preview_header.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
///dart imports
import 'dart:developer';
import 'dart:io';

///Package imports
Expand Down Expand Up @@ -69,6 +70,13 @@ class PreviewHeader extends StatelessWidget {
)
: Image.network(
HMSRoomLayout.roleLayoutData!.logo!.url!,
errorBuilder: (context, exception, _) {
log('Error is $exception');
return const SizedBox(
width: 30,
height: 30,
);
},
height: 30,
width: 30,
),
Expand Down
10 changes: 10 additions & 0 deletions packages/hms_room_kit/lib/src/preview_for_role/preview_for_role_header.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
///Dart imports
import 'dart:developer';

///Package imports
import 'package:flutter/cupertino.dart';
import 'package:flutter_svg/flutter_svg.dart';
Expand Down Expand Up @@ -37,6 +40,13 @@ class _PreviewForRoleHeaderState extends State<PreviewForRoleHeader> {
HMSRoomLayout.roleLayoutData!.logo!.url!)
: Image.network(
HMSRoomLayout.roleLayoutData!.logo!.url!,
errorBuilder: (context, exception, _) {
log('Error is $exception');
return const SizedBox(
width: 30,
height: 30,
);
},
height: 30,
width: 30,
),
Expand Down
Loading