Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused addTrackByDefault Property #1667

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Removed unused addTrackByDefault Property #1667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/hms_room_kit/lib/src/widgets/common_widgets/video_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,6 @@ class _VideoViewState extends State<VideoView> {
// Similarly to avoid rebuilding the key should be kept the same for particular HMSVideoView.
child: HMSTextureView(
controller: widget.videoViewController,
addTrackByDefault:
!context.read<PeerTrackNode>().isOffscreen,
key: Key(data.item1!.trackId),
scaleType: ScaleType.SCALE_ASPECT_FIT,
track: data.item1!,
Expand All @@ -98,8 +96,6 @@ class _VideoViewState extends State<VideoView> {
// Similarly to avoid rebuilding the key should be kept the same for particular HMSVideoView.
child: HMSTextureView(
controller: widget.videoViewController,
addTrackByDefault:
!context.read<PeerTrackNode>().isOffscreen,
key: Key(data.item1!.trackId),
scaleType: ScaleType.SCALE_ASPECT_FILL,
track: data.item1!,
Expand Down
9 changes: 0 additions & 9 deletions packages/hmssdk_flutter/lib/src/ui/meeting/hms_texture_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ import 'package:hmssdk_flutter/hmssdk_flutter.dart';
/// **key** - [key] property can be used to forcefully rebuild the video widget by setting a unique key everytime.
/// Similarly to avoid rebuilding the key should be kept the same for particular HMSVideoView.
///
/// **addTrackByDefault** - To call addTrack by default as HMSTextureView is attached to the tree. Default value is [true]
///
/// **controller** - To control the video view, this is useful for custom usecases when you wish to control the addTrack and removeTrack
/// track functionalities on your own.
///
Expand All @@ -58,9 +56,6 @@ class HMSTextureView extends StatelessWidget {
/// Default is [false]
final bool disableAutoSimulcastLayerSelect;

/// [addTrackByDefault] - To call addTrack by default as HMSVideoView is attached to the tree. Default value is [true]
final bool addTrackByDefault;

/// [controller] - To control the video view, this is useful for custom usecases when you wish to control the addTrack and removeTrack
/// track functionalities on your own.
final HMSTextureViewController? controller;
Expand All @@ -71,7 +66,6 @@ class HMSTextureView extends StatelessWidget {
this.setMirror = false,
this.scaleType = ScaleType.SCALE_ASPECT_FIT,
this.disableAutoSimulcastLayerSelect = false,
this.addTrackByDefault = true,
this.controller})
: super(key: key);

Expand All @@ -82,7 +76,6 @@ class HMSTextureView extends StatelessWidget {
setMirror: setMirror,
scaleType: this.scaleType,
disableAutoSimulcastLayerSelect: disableAutoSimulcastLayerSelect,
addTrackByDefault: addTrackByDefault,
controller: controller,
);
}
Expand All @@ -93,7 +86,6 @@ class _PlatformView extends StatefulWidget {
final bool setMirror;
final ScaleType scaleType;
final bool disableAutoSimulcastLayerSelect;
final bool addTrackByDefault;
final HMSTextureViewController? controller;

_PlatformView(
Expand All @@ -102,7 +94,6 @@ class _PlatformView extends StatefulWidget {
this.setMirror = false,
required this.scaleType,
this.disableAutoSimulcastLayerSelect = false,
this.addTrackByDefault = true,
this.controller})
: super(key: key);

Expand Down
Loading