Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUMP] Update dependency ember-template-lint to v6 (mon-pix) #11067

Open
wants to merge 26 commits into
base: dev
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 10, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
ember-template-lint ^5.13.0 -> ^6.0.0 age adoption passing confidence

Release Notes

ember-template-lint/ember-template-lint (ember-template-lint)

v6.0.0

Compare Source

💥 Breaking Change
  • #​3029 Enable more recommended rules: no-action-on-submit-button, no-at-ember-render-modifiers, no-builtin-form-components, no-unnecessary-curly-parens, no-unnecessary-curly-strings, simple-modifiers (@​bmish)
  • #​3031 Replace 4-x-recommended config with 5-x-recommended (@​bmish)
  • #​3023 Drop support for Node 14, 16, 19 (@​Techn1x)
  • #​2913 Add additional elements to DOCUMENT_STRUCTURE_ROLES for no-invalid-role rule (@​mrloop)
  • #​2729 Add param to obsolete list in no-obsolete-elements rule (@​geneukum)
🏠 Internal
Committers: 4

Tracking issue: https://github.com/ember-template-lint/ember-template-lint/issues/2712


Configuration

📅 Schedule: Branch creation - "every 1 hour every weekday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Jan 10, 2025
@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@yaf yaf force-pushed the renovate/mon-pix-ember-template-lint-6.x branch from b2386b6 to 353e255 Compare January 14, 2025 10:12
@yaf yaf self-assigned this Jan 14, 2025
@yaf yaf force-pushed the renovate/mon-pix-ember-template-lint-6.x branch from ae53f5d to 8421601 Compare January 14, 2025 13:29
Copy link
Contributor Author

renovate bot commented Jan 14, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@lionelB lionelB force-pushed the renovate/mon-pix-ember-template-lint-6.x branch 2 times, most recently from fccf7da to b8fb51a Compare January 14, 2025 18:10
@lionelB
Copy link
Member

lionelB commented Jan 14, 2025

concernant les modifiers, j'ai revert le code fait sur le modifier on-event car en me documentant sur comment se passer des modifier, je suis tombé sur différentes manières de faire le will-destroy qui modifiaient moins de code.

  • en utilisant le hook willDestroy d'un composant glimmer
  • en utilisant la methode registerDesctructor(instane, () => {})
    J'ai préféré la deuxième méthode car elle permet de colocaliser les ajout / suppression d’évènement.

Pour les did-insert/ did-update j'ai réutilisé le modifier modifier-did-update et lui apportant une petite modif sur la manière dont il transmet les paramètres à la fonction de rappel (on avait un premier argument, puis un tableau de param. Maintenant on tout les param à la suite)
D'après la doc, le fait de passer des variables au modifier ré-éxecute le modifier si les paramètres changent donc meme comportement de did-update

@lionelB lionelB force-pushed the renovate/mon-pix-ember-template-lint-6.x branch from b8fb51a to bc71ebe Compare January 15, 2025 14:10
@lionelB lionelB requested a review from a team as a code owner January 15, 2025 14:10
@lionelB lionelB self-assigned this Jan 15, 2025
@lionelB lionelB force-pushed the renovate/mon-pix-ember-template-lint-6.x branch 2 times, most recently from bb9f24c to 9b2152a Compare January 16, 2025 08:26
@lionelB lionelB requested review from a team January 16, 2025 08:28
@lionelB
Copy link
Member

lionelB commented Jan 16, 2025

J'ai finalement utiliser le willDestroy plutot que registerDesctructor() car cela rendait les tests un peu flaky (un test marchait mais pas plusieurs)

@xav-car
Copy link
Contributor

xav-car commented Jan 16, 2025

Prescription FUNC à faire :

  • Rejoindre une campagne par son code ✅
  • Reconciliation SUP ✅
  • Reconciliation SCO ✅
  • Affichage double mire ( SCO ? ) ✅ (nécessite corrections CSS sur les inputs du formulaire à gauche)

@alicegoarnisson
Copy link
Contributor

alicegoarnisson commented Jan 16, 2025

Func OK pour prescription moyennant corrections CSS sur les inputs de la double mire d'authentification

@xav-car xav-car force-pushed the renovate/mon-pix-ember-template-lint-6.x branch from 461c2a2 to d7dfc3f Compare January 17, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file 👀 Func Review Needed team-acces team-certif team-evaluation PR relatives à l'expérience d'évaluation team-prescription Tech Review OK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants