[FEATURE] Modification de la position des éléments challenge (PIX-15935) #11117
+164
−150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
| gap: var(--pix-spacing-6x); | ||
| display: grid; | ||
| grid-row-gap: var(--pix-spacing-4x); | ||
| grid-column-gap: var(--pix-spacing-6x) ; |
There was a problem hiding this comment.
A déplacer sur la classe d'affichage de plusieurs colonnes.
rouxxi
force-pushed
the
pix-15935-challenge-illustration-embed-two-columns
branch
6 times, most recently
from
03f8338 to
9335a91
Compare
aurelie-crouillebois
added
👀 Tech Review Needed
👀 Func Review Needed
👀 Design Review Needed
and removed
Development in progress
labels
rouxxi
force-pushed
the
pix-15935-challenge-illustration-embed-two-columns
branch
from
9335a91 to
2986e61
Compare
aurelie-crouillebois
approved these changes
Jan 17, 2025
rouxxi
added
Func Review OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Problème
Actuellement les positionnements de nos éléments dans les challenge sont trop statique et ne répondent plus à nos besoins.
🥓 Proposition
🧃 Remarques
RAS
😋 Pour tester
Lancer les différentes missions et observer les positions des éléments ainsi que la présence de card autour de tous les élements sauf les webcomponent.
Challenge embed + form : https://junior-pr11117.review.pix.fr/challenges/challenge1WsEoJsk3eKGXB/preview ✅
Challenge illu + embed : https://junior-pr11117.review.pix.fr/challenges/challenge26Yz2B7gZOSkQX/preview ✅
Challenge illu + webcomponent : https://junior-pr11117.review.pix.fr/challenges/challenge2Lvw9tRtkV4SwH/preview ✅
Challenge embed seul : https://junior-pr11117.review.pix.fr/challenges/challengeOcCJKzl7VvoCT/preview ✅
Challenge illu + formulaire : https://junior-pr11117.review.pix.fr/challenges/challengeLdtoEpViBs69k/preview ✅
Challenge formulaire seul : https://junior-pr11117.review.pix.fr/challenges/challenge1vXb3dV4QFaGHh/preview ✅
Challenge leçon : https://junior-pr11117.review.pix.fr/challenges/challenge1qbvny3qmWdnlT/preview ✅