Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TECH] Créer un assessment result en statut annulée lorsqu'on annule et désannule une certification sur Pix Admin (PIX-16045). #11131

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from
Draft

[TECH] Créer un assessment result en statut annulée lorsqu'on annule et désannule une certification sur Pix Admin (PIX-16045). #11131

wants to merge 6 commits into from
+759 −134

Conversation

AndreiaPena
Copy link
Member

@AndreiaPena AndreiaPena commented Jan 15, 2025 •
edited by Steph0
Loading

🥞 Problème

Actuellement, lorsque le métier annule ou désannule une certification, on ne modifie que le booléen isCancelled sur le certification-course.

  • Perte d’historisation des statuts d’une certification.
  • Le statut annulée n’est pas identifié de la même façon que le validated et rejected

🥓 Proposition

  • Ajouter en plus du boolean isCancelled la creation d'un nouveau assessment-result avec un statut 'cancelled' au moment du scoring
    • on garde les infos de score (competences-marks, etc.)
    • on identifie le tributaire de l'action cote pix admin
  • Bloquer l'annulation de certification quand on est pas finalise
    • suite reponse metier "Aujoud’hui on utilise pas l’annulation pour des certifications non finalisees"

🧃 Remarques

😋 Pour tester

⚠️ Faire ce test deux fois : une fois pour une certif V2 et une fois pour une certif V3

  • Sur Pix Certif creer une session, ajouter un candidat, lui faire passer sa certif
  • Avant la finalisation, sur Pix Admin, aller sur sa certification (sessions de certification -> certification xxx) et tenter de l'annuler
    • Un message d'erreur doit apparaitre, faire un refresh, verifier que la certification n'est pas annulee
  • Si test OK, revenir sur Pix Certif, et finaliser la session
  • Sur Pix Admin, tenter a nouveau de cliquer sur le bouton d'annulation
    • pas d'erreur, verifier que le "status" est a annuler (en + du macaron annulee)
    • en base de donnee, voir que pour cette certification, un nouvel asserssment-result (le dernier) est "cancelled"
  • Si tout est OK, tenter de publier, et verifier sur Pix App que l7affichage candidat est toujours OK (message d'annuation)

@AndreiaPena AndreiaPena requested a review from a team as a code owner January 15, 2025 16:36
@AndreiaPena AndreiaPena self-assigned this Jan 15, 2025
@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@alexandrecoin alexandrecoin force-pushed the PIX-16045-create-assessment-result-when-status-cancelled branch 2 times, most recently from 1ee1841 to 16052c5 Compare January 16, 2025 13:40
@yaf yaf force-pushed the PIX-16045-create-assessment-result-when-status-cancelled branch 2 times, most recently from 1d6ca25 to 6c80303 Compare January 16, 2025 15:35
@alexandrecoin alexandrecoin force-pushed the PIX-16045-create-assessment-result-when-status-cancelled branch from 6c80303 to 595a066 Compare January 16, 2025 16:12
@Steph0 Steph0 force-pushed the PIX-16045-create-assessment-result-when-status-cancelled branch from 595a066 to 3e262be Compare January 16, 2025 16:15
@Steph0
Copy link
Contributor

Steph0 commented Jan 16, 2025 •
edited
Loading

Premier test func v2 (KO)

Decision equipe

  • Il faut faire le uncancel pour activer le cancel
  • On veut supprimer l'event dispatcher qui est deprecated et cree des soucis (rollback sans erreurs cote monitoring)

ℹ️ OK de pas pouvoir annuler si pas finalise

Screenshot_20250116_173611

⚠️ Soucis : l'annulation change rien niveau front meme si HTTP 204 recu, le isCancelled est a false (il devrait etre true)

image
image

@alexandrecoin alexandrecoin force-pushed the PIX-16045-create-assessment-result-when-status-cancelled branch from 3e262be to d33d490 Compare January 17, 2025 08:10
Steph0
Steph0 reviewed Jan 27, 2025
View reviewed changes
api/src/certification/session-management/application/cancellation-controller.js Outdated
const certificationCourseId = request.params.certificationCourseId;
await usecases.cancelCertificationCourse({ certificationCourseId });
const certificationCancelledEvent = await usecases.cancelCertificationCourse({ certificationCourseId, juryId });
await dependencies.events.eventDispatcher.dispatch(certificationCancelledEvent);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

@yaf yaf marked this pull request as draft January 27, 2025 09:52
@AndreiaPena AndreiaPena force-pushed the PIX-16045-create-assessment-result-when-status-cancelled branch 2 times, most recently from 5c5c109 to 327e23f Compare January 27, 2025 16:18
Steph0 and others added 4 commits January 27, 2025 17:19
@Steph0 @alexandrecoin
@P-Jeremy @yaf @AndreiaPena
✨ api: create cancelled status on assessment-result
bfb2e15 
Co-authored-by: Alexandre COIN <[email protected]>
Co-authored-by: Andreia Pena <[email protected]>
Co-authored-by: Yannick François <[email protected]>
@Steph0 @alexandrecoin @AndreiaPena
✨ new cancelled event
98c849c 
Co-authored-by: Alexandre COIN <[email protected]>
Co-authored-by: Andreia Pena <[email protected]>
@alexandrecoin @AndreiaPena
feat(api): prevent session from being cancelled when already finalized
edb7888
@yaf @AndreiaPena @Steph0
✨ feat(api): create cancel assessment result for V3 certif
9d2de58 
Co-authored-by: Andreia Pena <[email protected]>
Co-authored-by: Steph0 <[email protected]>
Co-authored-by: Alexandre Coin <[email protected]>
@AndreiaPena AndreiaPena force-pushed the PIX-16045-create-assessment-result-when-status-cancelled branch from 327e23f to 27bbc6e Compare January 27, 2025 16:48
@AndreiaPena AndreiaPena force-pushed the PIX-16045-create-assessment-result-when-status-cancelled branch from 27bbc6e to e405c81 Compare January 29, 2025 10:34
@AndreiaPena AndreiaPena changed the title [TECH] Créer un assessment result en statut annulée lorsqu'on annule une certification sur Pix Admin (PIX-16045). [TECH] Créer un assessment result en statut annulée lorsqu'on annule et désannule une certification sur Pix Admin (PIX-16045). Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steph0 Steph0 Steph0 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Steph0 Steph0

@alexandrecoin alexandrecoin

@AndreiaPena AndreiaPena

Labels
Development in progress 👀 Func Review Needed 👀 Tech Review Needed team-certif
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AndreiaPena @pix-bot-github @Steph0 @yaf @alexandrecoin