Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH] Ajouter un sous-composant d'affichage des actions sur une certification (PIX-16542). #11398

Conversation

Jeyffrey
Copy link
Contributor

@Jeyffrey Jeyffrey commented Feb 11, 2025

🥞 Problème

Dans l'objectif d'alléger le template admin/app/templates/authenticated/certifications/certification/informations.hbs, il est nécessaire de réussir à alléger son unique composant admin/app/components/certifications/certification/informations.gjs.

🥓 Proposition

Commencer à faire de la composition en créant un sous-composant qui gérera l'affichage des actions de la page "Certification > Informations".

😋 Pour tester

  • Aller sur une page de détails d'une certification sur Admin en RA.
  • Constater la non-régression des boutons d'action

@Jeyffrey Jeyffrey self-assigned this Feb 11, 2025
@Jeyffrey Jeyffrey changed the base branch from dev to pix-16534-create-certification-informations-state-component February 11, 2025 17:19
@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@Jeyffrey Jeyffrey force-pushed the pix-16534-create-certification-informations-state-component branch 2 times, most recently from 38d2886 to d042f5a Compare February 12, 2025 13:08
Base automatically changed from pix-16534-create-certification-informations-state-component to dev February 12, 2025 14:21
@Jeyffrey Jeyffrey force-pushed the pix-16542-create-certification-informations-global-actions-component branch 4 times, most recently from 5d5b287 to a1cfbc9 Compare February 13, 2025 13:23
@Jeyffrey Jeyffrey added 👀 Tech Review Needed 👀 Func Review Needed Need PO validation for this functionally and removed Development in progress labels Feb 13, 2025
@Jeyffrey Jeyffrey marked this pull request as ready for review February 13, 2025 13:24
@Jeyffrey Jeyffrey force-pushed the pix-16542-create-certification-informations-global-actions-component branch 4 times, most recently from 5d850ee to 0fe24d9 Compare February 14, 2025 13:34
@AndreiaPena
Copy link
Member

Les textes de la modale ne se mettent pas à jour si on passe de l'annulation au rejet

Enregistrement.de.l.ecran.2025-02-14.a.16.12.03.mov

@Jeyffrey
Copy link
Contributor Author

Les textes de la modale ne se mettent pas à jour si on passe de l'annulation au rejet

Bien vu !
Je viens de check, c'était déjà le cas avant, mais ça permet de rectifier ça :)

@Jeyffrey Jeyffrey force-pushed the pix-16542-create-certification-informations-global-actions-component branch 2 times, most recently from 2f82b0d to f6a5c14 Compare February 14, 2025 16:27
@yaf yaf added the Func Review OK PO validated functionally the PR label Feb 17, 2025
@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-16542-create-certification-informations-global-actions-component branch from f6a5c14 to 4faa7f6 Compare February 17, 2025 13:33
@pix-service-auto-merge pix-service-auto-merge merged commit 1dcd24d into dev Feb 17, 2025
7 of 11 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the pix-16542-create-certification-informations-global-actions-component branch February 17, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants