[TECH] Ajouter cappedTubes requirement (PIX-???) #11421
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
laura-bergoens
commented
Feb 14, 2025
| for (const { tubeId, level } of cappedTubes) { | ||
| sumTotal += level; // ceci est très cavalier, je présuppose que le référentiel n'a aucun trou \o/ | ||
| const dataForTubeId = this.#dataByTubeId[tubeId] ?? []; | ||
| sumValidated += dataForTubeId.filter(({ isValidated, difficulty }) => isValidated && difficulty <= level).length; |
There was a problem hiding this comment.
edge case qui existe : possible d'avoir 2 ke qui pointent vers un acquis de meme tube et de meme niveau, mais pas le meme id d'acquis
il faut donc idéalement compter que "une" fois les acquis de même niveau
laura-bergoens
force-pushed
the
tech-everything-is-a-requirement-and-adding-capped-tube-requirement
branch
from
091e833 to
5445cd1
Compare
laura-bergoens
force-pushed
the
pix-16375-add-eligibility-requirement-that-checks-if-participation-has-ended
branch
from
b067a11 to
7719619
Compare
laura-bergoens
force-pushed
the
tech-everything-is-a-requirement-and-adding-capped-tube-requirement
branch
from
5445cd1 to
de0770e
Compare
…inations Co-authored-by: Yvonnick Frin <[email protected]> Co-authored-by: Xavier Carron <[email protected]>
…le truc) Co-authored-by: Yvonnick Frin <[email protected]> Co-authored-by: Xavier Carron <[email protected]>
Co-authored-by: Laura BERGOENS <[email protected]>
Co-authored-by: Yvonnick Frin <[email protected]> Co-authored-by: Xavier Carron <[email protected]>
Co-authored-by: Yvonnick Frin <[email protected]> Co-authored-by: Xavier Carron <[email protected]>
…ased on a subset of skillids
…nstances of base requirements
xav-car
force-pushed
the
tech-everything-is-a-requirement-and-adding-capped-tube-requirement
branch
from
de0770e to
c945fac
Compare
xav-car
changed the base branch from
pix-16375-add-eligibility-requirement-that-checks-if-participation-has-ended
to
pix-16445-refacto-quests
xav-car
changed the title
laura-bergoens
force-pushed
the
pix-16445-refacto-quests
branch
from
33312a3 to
6cadbff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Problème
🥓 Proposition
🧃 Remarques
On peut séparer les deux derniers commits du reste pour avoir un truc mergeable
😋 Pour tester