Add a block based theme option #238
Conversation
|
CC: @10up/editorial-engineering Would love to get your all's input on this :) Also CC: @darylldoyle we can use this new scaffold to update how we are doing things. So if we want to introduce larger coding style / structural changes this is a time where we can include stuff like that :) |
|
I'll also share with the FEE Best Practices WG - as some of the suggested and similar changes here have been discussed in that WG |
There was a problem hiding this comment.
@fabiankaegy I saw this PR in my notifications and thought I'd leave some comments. Feel free to disregard anything that is not relevant. It looks great! Excited for block themes
themes/10up-block-theme/.eslintrc
Outdated
There was a problem hiding this comment.
thought: we should add this to the .editorconfig file and make sure it's formatted like the other rc files.
https://github.com/10up/wp-scaffold/blob/trunk/.editorconfig#L10
There was a problem hiding this comment.
question: should we be using a cache for performance (e.g. https://github.com/roots/bedrock-autoloader/blob/master/src/Autoloader.php) and perhaps RecursiveDirectoryIterator instead of glob?
There was a problem hiding this comment.
I agree here. @fabiankaegy can we get an issue to follow up on this? It's not block theme dependent, so no need to block this PR
|
This should be ready for another set of reviews :) Would love to get it merged soon in the new year 🚀 |
There was a problem hiding this comment.
I agree here. @fabiankaegy can we get an issue to follow up on this? It's not block theme dependent, so no need to block this PR
Description of the Change
Adds a new Block Theme scaffold to the repository
Changelog Entry
Added - A new Block-Based Theme Scaffold
Credits
Props @fabiankaegy @tobeycodes @darylldoyle @colinswinney