Complete type hints for public API #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for finding this. I want to type my interfaces but I somehow forgot it here. Typing the whole implementation is currently not my goal. |
|
New release next week, I have a busy weekend 😉 |
Enjoy! No rush :-) |
15r10nk
pushed a commit
that referenced
this pull request
Apr 23, 2024
|
new pysource-minimize/codegen releases are out. Thank you for your contributions ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fills in type annotations for the parameters in
minimize()that are currently unannotated.If you're not all that interested in typing then obviously feel free to close this :-) but it would be a minor quality-of-life improvement for me -- currently pyright
--strictcomplains whenever I use this function, due to some of the parameters not have type annotations ;-)