Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Standard Ruby, Standard JS style checkers #3837

Merged
merged 3 commits into from
May 21, 2024
Merged

Conversation

beechnut
Copy link
Contributor

Pull request summary

Added standard (JS) and standardrb (Ruby) style checking libraries to reduce unnecessary configuration/bikeshedding, and to clean up the project root.

Fixes all JS and Ruby style issues. A handful of fixes were "unsafe" but simple, and all the tests continue to pass.

Closes #3827

Added standard (JS) and standardrb (Ruby) style checking libraries to reduce bikeshedding.

Fixes all JS and Ruby style issues. A handful of fixes were "unsafe" but simple, and all the tests continue to pass.
@beechnut beechnut requested a review from a team as a code owner May 21, 2024 15:27
Copy link
Contributor

@cantsin cantsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this LGTM after checks pass. There's a lot of code formatting changes but I trust in the veracity of our tests :)

@beechnut beechnut merged commit 1ce82e5 into main May 21, 2024
5 checks passed
@beechnut beechnut deleted the beechnut/standard-ruby-js branch May 21, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to Standard Ruby
2 participants