add ext with command before add #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iArtemv
changed the title
iArtemv
changed the title
|
@iArtemv было бы неплохо не хардкодить команду - а брать настройку из проекта. Например, завести реквизит(ы) в проекте из которого добавлять команды в до/после коммита. |
marmyshev
reviewed
Jul 18, 2020
| @@ -0,0 +1,291 @@ | |||
|
|
|||
| &Вместо("ЗаписатьФайлыКоммитаВерсии") | |||
There was a problem hiding this comment.
Заменять такую важную процедуру - не хорошо. Может быть сделать рефакторинг в проекте и вынести подключаемые места? Например разнести отдельно формирования текста команд, отдельно запись файла - потом можно дообработать тексты команд в расширении.
Кажется текущая функция уже переделанная в Конфигурации.
There was a problem hiding this comment.
У тебя как раз было запланировано сделать рефакторинг, я посмотрю как это сейчас. Тут я просто выложил что было.
|
@iArtemv теперь в мастер надо... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#109