CodeQuality имеет 1-based номера строк

1c-syntax · Feb 22, 2025 · c85c91f · c85c91f
1 parent 375e5f3
commit c85c91f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/main/java/com/github/_1c_syntax/bsl/languageserver/reporters/CodeQualityReportEntry.java b/src/main/java/com/github/_1c_syntax/bsl/languageserver/reporters/CodeQualityReportEntry.java
@@ -78,7 +78,7 @@ public CodeQualityReportEntry(String path, Diagnostic diagnostic, DiagnosticInfo
     this.location = new Location();
     this.location.path = path;
     this.location.lines = new Lines();
-    this.location.lines.begin = diagnostic.getRange().getStart().getLine();
+    this.location.lines.begin = diagnostic.getRange().getStart().getLine() + 1;
   }
 
   @Getter
@@ -100,7 +100,7 @@ public static class Location {
   @ToString
   public static class Lines {
     /**
-     * The line on which the code quality violation occurred.
+     * The line on which the code quality violation occurred (1-based).
      */
     private int begin;
   }

diff --git a/...t/java/com/github/_1c_syntax/bsl/languageserver/reporters/CodeQualityReportEntryTest.java b/...t/java/com/github/_1c_syntax/bsl/languageserver/reporters/CodeQualityReportEntryTest.java
@@ -57,7 +57,7 @@ void testConstructor() {
       .hasFieldOrPropertyWithValue("checkName", "Typo")
       .hasFieldOrPropertyWithValue("severity", CodeQualityReportEntry.Severity.INFO)
       .hasFieldOrPropertyWithValue("location.path", "file.txt")
-      .hasFieldOrPropertyWithValue("location.lines.begin", 0)
+      .hasFieldOrPropertyWithValue("location.lines.begin", 1)
     ;
   }