Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SC-861] Migrate to new hardhat-ethers #18

Merged
merged 15 commits into from
Aug 25, 2023

Conversation

byshape
Copy link
Contributor

@byshape byshape commented Jul 6, 2023

To support ethers v6, hardhat-ethers and some other dependencies need to be updated. In addition to updating the versions of the relevant dependencies, changes have been made to .js files that used the functionality of ethers v5, which has been changed in the new version.

@byshape byshape requested review from ZumZoom and galekseev July 6, 2023 13:33
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7ab36bb) 83.33% compared to head (67f0cdb) 83.33%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   83.33%   83.33%           
=======================================
  Files           3        3           
  Lines          78       78           
  Branches       13       13           
=======================================
  Hits           65       65           
  Misses         13       13           
Files Changed Coverage Δ
contracts/CumulativeMerkleDrop.sol 100.00% <100.00%> (ø)
contracts/CumulativeMerkleDrop128.sol 100.00% <100.00%> (ø)
contracts/SignatureMerkleDrop128.sol 69.04% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@byshape byshape marked this pull request as draft July 6, 2023 19:28
@byshape byshape marked this pull request as ready for review July 7, 2023 15:17
Co-authored-by: Mikhail Melnik <[email protected]>
@ZumZoom ZumZoom merged commit a0ecf06 into master Aug 25, 2023
@ZumZoom ZumZoom deleted the SC-861-Migrate-to-new-hardhat-ethers branch August 25, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants