Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISC] Removal of openHAB specific MQTT discovery patch #2153

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

DigiH
Copy link
Collaborator

@DigiH DigiH commented Jan 18, 2025

Removal of openHAB specific MQTT discovery patch "ohdisc", as it is no longer required with openHAB 4.3 and later, and with openHAB before 4.3 MQTT discovery never was fully implemented anyway.

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

@DigiH DigiH requested a review from 1technophile January 18, 2025 16:48
Copy link
Owner

@1technophile 1technophile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also remove:

// Set the line below to true so as to have autodiscovery working with OpenHAB
#ifndef OpenHABDiscovery
#  define OpenHABDiscovery false
#endif

From config_mqttDiscovery.h

Removal of openHAB specific MQTT discovery patch "ohdisc", as it is no longer required with openHAB 4.3 and later, and with openHAB before 4.3 MQTT discovery never was fully implemented anyway.
@DigiH
Copy link
Collaborator Author

DigiH commented Jan 25, 2025

You could also remove:

True, I missed that one. thanks. Done

@DigiH DigiH reopened this Jan 25, 2025
@1technophile
Copy link
Owner

Thanks

@1technophile 1technophile merged commit 4bf43f5 into 1technophile:development Jan 25, 2025
77 checks passed
@DigiH DigiH deleted the remove_ohdisc branch January 26, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants