Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Halobox memory improvements #380

Merged
merged 4 commits into from
Apr 22, 2024
Merged

Halobox memory improvements #380

merged 4 commits into from
Apr 22, 2024

Conversation

daviesje
Copy link
Contributor

This small change explicitly purges the HaloBox fields which are no longer required at each timestep. The SFR at previous redshifts is used to construct the XraySourceBox but we don't need the other fields.

Copy link
Member

@steven-murray steven-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This looks correct to me. Does this need to also be done run_coeval?

@daviesje
Copy link
Contributor Author

Thanks, I've made the changes to the coeval function, noting that the issues in #376 to do with the coeval boxes remain.

@daviesje daviesje merged commit d257b08 into v4-prep Apr 22, 2024
3 of 4 checks passed
@daviesje daviesje deleted the halobox-memory-improvements branch April 22, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants