-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Menu): MenuItemの高さが小さい画面で崩れるのを修正 #1549
Conversation
🦋 Changeset detectedLatest commit: 2adab72 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
PR-Agent was enabled for this repository. To use it, please link your git user with your CodiumAI identity here. PR Description updated to latest commit (e1764ba)
|
PR-Agent was enabled for this repository. To use it, please link your git user with your CodiumAI identity here. PR Review
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
Deploying for-ui with
|
Latest commit: |
2adab72
|
Status: | ✅ Deploy successful! |
Preview URL: | https://dbdf6072.for-ui.pages.dev |
Branch Preview URL: | https://fix-menuitem-in-small-window.for-ui.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
User description
チケット
実装内容
スクリーンショット
相談内容(あれば)
Type
bug_fix
Description
MenuItem
component to ensure it displays correctly in small window sizes.Changes walkthrough
MenuItem.tsx
Reset `MenuItem` Component's Minimum Height
packages/for-ui/src/menu/MenuItem.tsx
min-h-[unset]
to theMenuItem
component to reset its minimumheight.