-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Drop python 3.8 #1206
Merged
Merged
chore: Drop python 3.8 #1206
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
071109e
chore: Drop python 3.8
Czaki f8ebccf
bump black
Czaki 82ca4f7
Merge remote-tracking branch 'origin/develop' into drop_python3.8
Czaki b68789d
bump requirements
Czaki 3aacae8
pin typing-extensions
Czaki 86d423e
improve docstrings
Czaki b4eb02e
fix workflows
Czaki d4f81f9
fix specifing napari version in test
Czaki 07918b8
fix tox napari 5_4
Czaki 44c8b76
try fix warning
Czaki 96a20d2
fix tox
Czaki 4e7e31f
use setFontFamilies
Czaki c06e15d
fix problems pointed by last review
Czaki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Potential Compatibility Issues with Python 3.11
The update to Python 3.11 may introduce compatibility issues due to existing version-specific checks in the codebase:
Test Skipping for Python >= 3.10:
pytest.mark.skipif(sys.version_info >= (3, 10), reason="class register is not compatible with python 3.10+")
Version Requirements:
@pytest.mark.skipif(sys.version_info < (3, 9), reason="requires python 3.9 or higher")
if sys.version_info < (3, 10):
if sys.version_info[:3] != (3, 9, 7):
if sys.version_info[:3] == (3, 9, 7):
These checks indicate that the code is not currently designed to support Python versions above 3.10, which includes the proposed 3.11 update.
Action Items:
sys.version_info
checks to include support for Python 3.11.🔗 Analysis chain
Approved: Python version update in GetTestData stage
The update from Python 3.9 to 3.11 in the
GetTestData
stage is consistent with the PR objective of dropping support for older Python versions. This change could potentially improve performance and allow the use of newer Python features.To ensure this change doesn't introduce any compatibility issues, please verify:
GetTestData
stage are compatible with Python 3.11.You can use the following script to check for any Python version-specific code or dependencies in the repository:
This script will help identify any potential compatibility issues that might arise from updating the Python version.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 826
Script:
Length of output: 1278