Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 11.x Compatibility #172

Merged
merged 2 commits into from
May 5, 2024

Conversation

laravel-shift
Copy link
Contributor

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 11.x.

Before merging, you need to:

  • Checkout the l11-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Contributor Author

⚠️ The latest version of Laravel has a dependency for phpunit/phpunit of ^10.5. If you would like to also upgrade your tests, you may run the PHPUnit 10 Shift for free.

@laravel-shift
Copy link
Contributor Author

⚠️ Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 11. However, you should review these changes to ensure the desired combination of versions are built for your package.

@laravel-shift
Copy link
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/laravel-notion-api.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "fiveam-code/laravel-notion-api": "dev-l11-compatibility",
    }
}

Finally, run: composer update

Copy link

what-the-diff bot commented Mar 2, 2024

PR Summary

  • Expansion of Triggered Events
    The workflow configuration now recognizes more actions. It will activate not only when code is manually pushed, but will respond to other workflow actions.

  • Broadened Compatibility
    The system compatibility range has been expanded. Additional versions of PHP, Laravel, and Testbench have been included, ensuring our service works smoothly across more systems.

  • Inclusive Updates
    Additional versions for Laravel and Testbench have been included for testing purposes, making sure every potential use-case has been catered to.

  • Preventive Measures
    Certain combinations of older PHP versions with newest Laravel version have been excluded from testing to prevent unlikely compatibility.

  • Support Added
    Support for a newer version of illuminate/support has been added to the program's core features, ensuring our product stays up to date.

  • Development Tools Updates
    Important updates have been made in the development tools section. They now include latest versions for the test environment, enabling an efficient and thorough testing process.

@hermanschutte
Copy link

Any chance getting this PR merged? Would love to use this in a new Laravel 11 project.

@johguentner
Copy link
Member

Any chance getting this PR merged? Would love to use this in a new Laravel 11 project.

I'm having a look into this and trying to merge this soon.

@johguentner johguentner changed the base branch from main to dev May 5, 2024 04:01
@johguentner johguentner merged commit 633a1a5 into 5am-code:dev May 5, 2024
1 check passed
@johguentner
Copy link
Member

With #174 laravel-notion-api (v1.2.0) supports Laravel 11.x

  • all tests are running smoothly and I tested various scenarious directly with the Notion API
  • if you find any issues, while running laravel-notion-api with Laravel 11.x, please open an issue and description what happened; thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants