Fix "Learned!" text always showing even for already known items

62832 · May 10, 2024 · 62d7cb1 · 62d7cb1
1 parent b743359
commit 62d7cb1
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/main/java/gripe/_90/appliede/me/service/EMCStorage.java b/src/main/java/gripe/_90/appliede/me/service/EMCStorage.java
@@ -199,18 +199,19 @@ public long insertItem(
 
         if (mode == Actionable.MODULATE && mayLearn && totalInserted > 0) {
             source.player().ifPresent(player -> {
-                if (playerProvider != null) {
+                if (playerProvider != null && !playerProvider.get().hasKnowledge(what.toStack())) {
                     addKnowledge(what, playerProvider.get(), player);
+                    onLearn.run();
                 }
             });
             source.machine().ifPresent(host -> {
-                if (machineProvider != null) {
+                if (machineProvider != null && !machineProvider.get().hasKnowledge(what.toStack())) {
                     var node = Objects.requireNonNull(host.getActionableNode());
                     var player = IPlayerRegistry.getConnected(node.getLevel().getServer(), node.getOwningPlayerId());
                     addKnowledge(what, machineProvider.get(), player);
+                    onLearn.run();
                 }
             });
-            onLearn.run();
         }
 
         return totalInserted;