Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes TLS upgrade and adds support for client cert verification #29

Open
wants to merge 2 commits into
base: feature/tls
Choose a base branch
from
Open

Fixes TLS upgrade and adds support for client cert verification #29

wants to merge 2 commits into from

Conversation

wafflespeanut
Copy link

fixes #27

@wafflespeanut
Copy link
Author

cc @OtaK

@wafflespeanut wafflespeanut changed the title Fixes TLS upgrade and adds support for client-side verification Fixes TLS upgrade and adds support for client cert verification Mar 9, 2019
@gpeers
Copy link

gpeers commented Apr 12, 2019

cc @OtaK @wafflespeanut
hiya, just wondering about the status of this pr and if it will be merged anytime soon. the fix would be really useful to us! many thanks.

@OtaK
Copy link
Contributor

OtaK commented Apr 14, 2019

Hey,

I haven't had a chance to review it properly yet, I'll do it this week for sure.
From what I've seen there are some things that are not the cleanest but they can be refactored afterwards as long as we can land the feature ASAP.

I'll keep you posted @gpeers ;)

Cheers,

@OtaK OtaK changed the base branch from master to feature/tls April 24, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wafflespeanut @gpeers @OtaK