Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): 회원가입 페이지 UI #160

Merged
merged 5 commits into from
Jan 8, 2024
Merged

feat(web): 회원가입 페이지 UI #160

merged 5 commits into from
Jan 8, 2024

Conversation

leekh716
Copy link
Contributor

작업 이유

회원가입을 하고 싶어서...!

작업 사항

2023-10-21.18.11.59.mov

이슈 연결

@leekh716 leekh716 requested a review from a team as a code owner October 21, 2023 09:13
@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2023

⚠️ No Changeset found

Latest commit: c2c4584

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment on lines +207 to +208
/** TODO: nickname 가능 여부에 따른 메시지 변경 */
description={nickname ? '사용 가능한 닉네임이에요.' : '팔만코딩경에서 사용할 닉네임을 입력해 주세요.'}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이쪽은 닉네임 관련 정책 스펙이 확정되고 api 가 생긴 이후에 닉네임 키보드 타이핑마다 디바운스로 유효성체크해서 바꿔줄 예정입니다.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2023

Chromatic Report

🚀 Congratulations! Your build was successful!

Comment on lines +238 to +242
<div className='sub-body-3A text-gray-400'>
이용약관에 대한 설명입니다. 잘 읽고 동의하시면 체크박스에 체크해주세요 이용약관에 대한 설명입니다. 잘 읽고 동의하시면 체크박스에
체크해주세요이용약관에 대한 설명입니다. 잘 읽고 동의하시면 체크박스에 체크해주세요 이용약관에 대한 설명입니다. 잘 읽고
동의하시면 체크박스에 체크해주세요 이용약관에 대한 설명입니다.{' '}
</div>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋㅋㅋㅋ내용 추가되면 변경 예정

Comment on lines +246 to +247
<div>서비스 이용 약관</div>
<div>개인정보처리방침</div>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분은 클릭시 따로 모달이 열려서 약관을 보여줄지 등 스펙 확정필요

@rkskekzzz
Copy link
Contributor

/signup으로 들어가니까 터지네용.. 혹시 로컬환경에서 잘 되시나여?

@rkskekzzz
Copy link
Contributor

/signup으로 들어가니까 터지네용.. 혹시 로컬환경에서 잘 되시나여?

요건 해결했습니다!

Copy link
Contributor

@rkskekzzz rkskekzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

@rkskekzzz rkskekzzz merged commit 922ae5e into dev Jan 8, 2024
1 check passed
@rkskekzzz rkskekzzz deleted the feat/signup branch January 8, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants