Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in CI pipeline + Implement multi staged build in to two separated Images #55

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

shakyapeiris
Copy link

@shakyapeiris shakyapeiris commented Oct 16, 2021

I have made some changes and the purpose of this pull request is to discuss about the changes I made up to now(I'm planning to do more improvements as mentioned below).

Implemented:

  • Add test step to GitHub actions
  • Fixed issues with unit tests in the server/api (with jest and mongodb-memory-server)
  • Separate front-end and back-end in to two Docker images (client image didn't built successfully)
  • Implement multi-staged build in Images/Dockerfiles
  • Update docker-compose.yml according to implemented changes in Images/Dockerfiles.
  • Add Dockerfile and .dockerignore files to each respective .dockerignore files.

Future:

  • Write all the tests for api
  • Fix issues with the client image
  • Fix issues with dependencies
  • Add docker image build step to the GitHub action

Thank You
Shakya Peiris

Sorry, something went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant