chore(cmd): unify assert parameters

- fix order of parameters to match expected and actual

Signed-off-by: AtomicFS <[email protected]>

cmd/firmware-action/filesystem/filesystem_test.go

@@ -110,7 +110,7 @@ func TestLastSaveRunTime(t *testing.T) {
 	// Load - should fallback because no file exists, but no error
 	loadTime, err := LoadLastRunTime(pathTimeFile)
 	assert.NoError(t, err)
-	assert.Equal(t, loadTime, time.Time{})
+	assert.Equal(t, time.Time{}, loadTime)
 	assert.ErrorIs(t, CheckFileExists(pathTimeFile), os.ErrNotExist)
 
 	// Save
@@ -133,7 +133,7 @@ func TestGetFileModTime(t *testing.T) {
 	// Missing file - should fail
 	modTime, err := GetFileModTime(pathFile)
 	assert.ErrorIs(t, err, os.ErrNotExist)
-	assert.Equal(t, modTime, time.Time{})
+	assert.Equal(t, time.Time{}, modTime)
 	assert.ErrorIs(t, CheckFileExists(pathFile), os.ErrNotExist)
 
 	// Make file

cmd/firmware-action/filesystem/git_test.go

@@ -56,7 +56,7 @@ func TestGitRun(t *testing.T) {
 	// Test git status
 	stdout, err := gitRun("./", []string{"git", "status"})
 	assert.NoError(t, err)
-	assert.Equal(t, stdout, "On branch master\nnothing to commit, working tree clean\n")
+	assert.Equal(t, "On branch master\nnothing to commit, working tree clean\n", stdout)
 }
 
 func TestGitDescribeCoreboot(t *testing.T) {
@@ -73,7 +73,7 @@ func TestGitDescribeCoreboot(t *testing.T) {
 	// Test git status
 	describe, err := GitDescribeCoreboot("./")
 	assert.NoError(t, err)
-	assert.Equal(t, describe, "4eeb1eaf0c81")
+	assert.Equal(t, "4eeb1eaf0c81", describe)
 	// This magic value comes from manual execution of the test
 	// Since the content, author and time of the commit are hard-coded,
 	//   the commit hash is always the same

cmd/firmware-action/recipes/linux_test.go

@@ -155,8 +155,10 @@ func TestLinux(t *testing.T) {
 			assert.ErrorIs(t, err, tc.wantErr)
 
 			// Check artifacts
-			assert.ErrorIs(t, filesystem.CheckFileExists(filepath.Join(outputPath, "vmlinux")), os.ErrExist)
-			assert.ErrorIs(t, filesystem.CheckFileExists(filepath.Join(outputPath, "defconfig")), os.ErrExist)
+			if tc.wantErr == nil {
+				assert.ErrorIs(t, filesystem.CheckFileExists(filepath.Join(outputPath, "vmlinux")), os.ErrExist)
+				assert.ErrorIs(t, filesystem.CheckFileExists(filepath.Join(outputPath, "defconfig")), os.ErrExist)
+			}
 		})
 	}
 	assert.NoError(t, os.Chdir(pwd)) // just to make sure

cmd/firmware-action/recipes/recipes_test.go

@@ -225,7 +225,7 @@ func TestBuild(t *testing.T) {
 					"edk2-build-b": {Depends: []string{}},
 				},
 				FirmwareStitching: map[string]FirmwareStitchingOpts{
-					"stitch":  {Depends: []string{"edk2-build-a"}},
+					"stitch": {Depends: []string{"edk2-build-a"}},
 				},
 			},
 		},
@@ -239,7 +239,7 @@ func TestBuild(t *testing.T) {
 					"edk2-build": {Depends: []string{}},
 				},
 				FirmwareStitching: map[string]FirmwareStitchingOpts{
-					"stitch-a":  {Depends: []string{"edk2-build"}},
+					"stitch-a": {Depends: []string{"edk2-build"}},
 					"stitch-b": {Depends: []string{"edk2-build"}},
 				},
 			},