Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/linter #417

Merged
merged 2 commits into from
Nov 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .dagger-ci/daggerci/lib/orchestrator.py
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,7 @@ async def __build__(
# "AttributeError: module 'dagger' has no attribute 'api'"

# pylint: disable=too-many-arguments
# pylint: disable=too-many-positional-arguments
"""
Does the actual building of docker container
"""
Expand Down
6 changes: 5 additions & 1 deletion .dagger-ci/daggerci/lib/results.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def __init__(self) -> None:
self.results: dict[str, dict[str, dict[str, str | bool | None]]] = {}

def add(
self, # pylint: disable=too-many-arguments
self,
top_element: str,
dockerfile: str,
stage: str,
Expand All @@ -34,6 +34,10 @@ def add(
"""
Add entry into results
"""

# pylint: disable=too-many-arguments
# pylint: disable=too-many-positional-arguments

# Update list of all dockerfiles
if [top_element, dockerfile] not in self.all_dockerfiles:
self.all_dockerfiles.append([top_element, dockerfile])
Expand Down
1 change: 1 addition & 0 deletions .dagger-ci/daggerci/tests/test_orchestrator.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# pylint: disable=missing-function-docstring
# pylint: disable=missing-module-docstring
# pylint: disable=too-many-arguments
# pylint: disable=too-many-positional-arguments
# pylint: disable=unused-import
# mypy: disable-error-code="import, no-untyped-def"

Expand Down
9 changes: 6 additions & 3 deletions action/filesystem/filesystem.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,12 @@ import (
)

var (
ErrEmptyPath = errors.New("provided path is empty") // ErrEmptyPath is returned when function is called with empty path parameter
ErrPathIsDirectory = fmt.Errorf("provided path is directory: %w", os.ErrExist) // ErrPathIsDirectory is returned when path exists, but is a directory and not a file
ErrFileNotRegular = errors.New("file is not regular file") // ErrFileNotRegular is returned when path exists, but is not a regular file
// ErrEmptyPath is returned when function is called with empty path parameter
ErrEmptyPath = errors.New("provided path is empty")
// ErrPathIsDirectory is returned when path exists, but is a directory and not a file
ErrPathIsDirectory = fmt.Errorf("provided path is directory: %w", os.ErrExist)
// ErrFileNotRegular is returned when path exists, but is not a regular file
ErrFileNotRegular = errors.New("file is not regular file")
)

// CheckFileExists checks if file exists at PATH
Expand Down
Loading