Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/move golang code #447

Merged
merged 6 commits into from
Jan 8, 2025
Merged

Chore/move golang code #447

merged 6 commits into from
Jan 8, 2025

Conversation

AtomicFS
Copy link
Collaborator

No description provided.

@AtomicFS AtomicFS requested a review from MDr164 as a code owner November 28, 2024 15:21
@github-actions github-actions bot added documentation Improvements or additions to documentation github_actions Pull requests that update GitHub Actions code labels Nov 28, 2024
@AtomicFS AtomicFS enabled auto-merge November 28, 2024 15:21
@AtomicFS AtomicFS force-pushed the chore/move-golang-code branch 5 times, most recently from f57ec20 to f710eae Compare December 2, 2024 13:00
@AtomicFS AtomicFS disabled auto-merge December 2, 2024 16:44
@AtomicFS AtomicFS force-pushed the chore/move-golang-code branch from f710eae to 94ca55c Compare December 3, 2024 11:48
@AtomicFS AtomicFS enabled auto-merge December 3, 2024 11:53
@AtomicFS AtomicFS force-pushed the chore/move-golang-code branch 2 times, most recently from d4c2db2 to 05a071e Compare December 5, 2024 16:24
@AtomicFS AtomicFS force-pushed the chore/move-golang-code branch from 05a071e to 2f93621 Compare December 11, 2024 10:15
@MDr164
Copy link
Collaborator

MDr164 commented Dec 11, 2024

Does this work as expected btw? If I recall correctly the reason to change it was due to how go install finds and names the binary, right?

@AtomicFS
Copy link
Collaborator Author

Does this work as expected btw? If I recall correctly the reason to change it was due to how go install finds and names the binary, right?

Yes, that is the reason. It should work, but I do not know how to actually test it.

@AtomicFS AtomicFS force-pushed the chore/move-golang-code branch from 2f93621 to 3a82035 Compare December 11, 2024 14:10
@MDr164
Copy link
Collaborator

MDr164 commented Dec 18, 2024

I'll try to test this out from the branch soon to check if this does what we want.

@AtomicFS AtomicFS force-pushed the chore/move-golang-code branch from 3a82035 to bd99632 Compare December 18, 2024 22:55
@AtomicFS AtomicFS force-pushed the chore/move-golang-code branch from bd99632 to 5b60b06 Compare December 30, 2024 14:05
@AtomicFS AtomicFS force-pushed the chore/move-golang-code branch 2 times, most recently from eace8e7 to 9975374 Compare January 7, 2025 09:16
@MDr164
Copy link
Collaborator

MDr164 commented Jan 8, 2025

I'll try to test this out from the branch soon to check if this does what we want.

❯ go install github.com/9elements/firmware-action/cmd/firmware-action@65d6577647f8224a70aa7f09fe4e199e603bb5fd
go: downloading github.com/9elements/firmware-action v0.10.3-0.20250107091606-65d6577647f8
go: downloading github.com/9elements/firmware-action/cmd/firmware-action v0.0.0-20250107091606-65d6577647f8

Looks like it is trying to fetch the right thing so should be fine to go in. I'll double check if everything is moved to the new path without any leftover references to the old one.

@MDr164
Copy link
Collaborator

MDr164 commented Jan 8, 2025

Needs one last rebase but should be good to go then

AtomicFS and others added 4 commits January 8, 2025 21:40
@AtomicFS @MDr164
chore(action): move golang code
2e88be6 
- 'go install' command uses the last elements in the path/url to
  determine name of the executable
- move golang code from ./action directory to ./cmd/firmware-action
  instead
- this way when people run 'go install' they get 'firmware-action'
  instead of just 'action'

Signed-off-by: AtomicFS <[email protected]>
@AtomicFS @MDr164
chore: cleanup after moving golang code
a0bbfee 
- change references in docs
- update gitignore
- update workflows
- update Taskfile
- hopefully I did not forget anything

Signed-off-by: AtomicFS <[email protected]>
@AtomicFS @MDr164
docs: add golang installation instructions
4d4a2b8 
Signed-off-by: AtomicFS <[email protected]>
@MDr164
docs: update remaining '/action' reference
a48e9b9 
Signed-off-by: Marvin Drees <[email protected]>
@AtomicFS
Copy link
Collaborator Author

AtomicFS commented Jan 8, 2025

Do you want to do it?

@MDr164 MDr164 force-pushed the chore/move-golang-code branch from 9172456 to c4efe91 Compare January 8, 2025 20:43
MDr164
MDr164 previously approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@MDr164 MDr164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hope this does not break anything 🤞

@MDr164
Copy link
Collaborator

MDr164 commented Jan 8, 2025

Need your approval as well @AtomicFS to merge

@AtomicFS
Copy link
Collaborator Author

AtomicFS commented Jan 8, 2025

It says that "Pull request authors can’t approve their own pull request."

@AtomicFS
Copy link
Collaborator Author

AtomicFS commented Jan 8, 2025

Just bypass the rules.

@MDr164
Copy link
Collaborator

MDr164 commented Jan 8, 2025 •
edited
Loading

It says that "Pull request authors can’t approve their own pull request."

Also says "New changes require approval from someone other than MDr164 because they were the last pusher." :D

Edit: Maybe push some random commit that changes punctuation or something.

@MDr164 @AtomicFS
chore: change go mod path and imports
b3cb6c5 
This simplifies the mod path now that we moved the code

Signed-off-by: Marvin Drees <[email protected]>
Signed-off-by: AtomicFS <[email protected]>
@AtomicFS AtomicFS force-pushed the chore/move-golang-code branch from c4efe91 to f8d26b0 Compare January 8, 2025 21:28
@AtomicFS
Copy link
Collaborator Author

AtomicFS commented Jan 8, 2025

Done

FYI, you also committed a compiled go executable, so I removed it ;)

@AtomicFS AtomicFS force-pushed the chore/move-golang-code branch from f8d26b0 to 5844007 Compare January 8, 2025 21:29
@AtomicFS AtomicFS requested a review from MDr164 January 8, 2025 21:33
@AtomicFS AtomicFS added this pull request to the merge queue Jan 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2025
@AtomicFS AtomicFS added this pull request to the merge queue Jan 8, 2025
@AtomicFS AtomicFS mentioned this pull request Jan 8, 2025
Merged
Merged via the queue into main with commit bbc46be Jan 8, 2025
68 checks passed
@AtomicFS AtomicFS deleted the chore/move-golang-code branch January 8, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDr164 MDr164 MDr164 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AtomicFS @MDr164