Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump all golang dependencies #483

Closed
wants to merge 1 commit into from
Closed

Conversation

AtomicFS
Copy link
Collaborator

manually run:

go get -u
go mod tidy

@AtomicFS AtomicFS requested a review from MDr164 as a code owner December 19, 2024 10:46
@AtomicFS AtomicFS enabled auto-merge December 19, 2024 10:46
@github-actions github-actions bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Dec 19, 2024
@AtomicFS
Copy link
Collaborator Author

Looks maybe like issue in dagger? No idea.

@MDr164
Copy link
Collaborator

MDr164 commented Dec 19, 2024

go get -u without a package (aka updating all of them) is prone to cause issues because it will update the indirect deps as well regardless of which version was pulled in by the direct deps. If the indirect ones get too new their API might change and therefore break code in the direct deps. I always refrain from a global go get -u and rather just call it only on the direct deps. So #482 should be enough to update our Go deps properly.

@AtomicFS
Copy link
Collaborator Author

Fair enough. I was just too lazy to debug #482, so I wanted to try this approach just in case it would work.

@AtomicFS
Copy link
Collaborator Author

Closed in favor of #482

@AtomicFS AtomicFS closed this Dec 19, 2024
auto-merge was automatically disabled December 19, 2024 11:41

Pull request was closed

@AtomicFS AtomicFS deleted the chore/deps-manual branch December 19, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants