Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker): downgrade NodeJS for udk2017 #508

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix(docker): downgrade NodeJS for udk2017 #508

merged 1 commit into from
Jan 20, 2025

Conversation

AtomicFS
Copy link
Collaborator

@AtomicFS AtomicFS commented Jan 20, 2025 •
edited
Loading

  • NodeJS v20 requires libc6 version >= 2.28, but that is not possible with this old Ubuntu
  • switching to newer Ubuntu is not a option either because of how fragile and snowflaky edk2 is
  • updating libc6 is just a terrible idea, that means that udk2017 cannot run NodeJS v20
  • the best we can do is to run v18, which is end-of-life soon, but that is the best we can do
  • UPDATE: the best we can do v16, everything else is too new for this old Ubuntu
  • still, it is much better than v10 that the Ubuntu Bionic (18.04) ships with

fixes #500

@AtomicFS AtomicFS requested a review from MDr164 as a code owner January 20, 2025 11:04
@github-actions github-actions bot added docker docker related bugfix Bugfix / fix module/edk2 labels Jan 20, 2025
@AtomicFS AtomicFS enabled auto-merge January 20, 2025 11:04
@AtomicFS AtomicFS force-pushed the fix/nodejs-for-udk2017 branch from ba1454a to f094114 Compare January 20, 2025 11:32
MDr164
MDr164 previously approved these changes Jan 20, 2025
View reviewed changes
@AtomicFS AtomicFS added this pull request to the merge queue Jan 20, 2025
@AtomicFS AtomicFS removed this pull request from the merge queue due to a manual request Jan 20, 2025
@AtomicFS AtomicFS changed the title fix(docker): downgrade to NodeJS v18 for udk2017 fix(docker): downgrade NodeJS for udk2017 Jan 20, 2025
@AtomicFS
Copy link
Collaborator Author

Wait, even v18 is too new. I am checking right now which is the newest NodeJS version we can actually run.

@AtomicFS AtomicFS force-pushed the fix/nodejs-for-udk2017 branch from f094114 to a5bc6a5 Compare January 20, 2025 11:58
@AtomicFS AtomicFS enabled auto-merge January 20, 2025 11:59
@AtomicFS
fix(docker): downgrade NodeJS for udk2017
4aedb3b 
- NodeJS v20 requires libc6 version >= 2.28, but that is not possible
  with this old Ubuntu
- switching to newer Ubuntu is not a option either because of how
  fragile and snowflaky edk2 is
- updating libc6 is just a terrible idea, that means that udk2017
  cannot run NodeJS v20
- this is the best we can do

Signed-off-by: AtomicFS <[email protected]>
@AtomicFS AtomicFS force-pushed the fix/nodejs-for-udk2017 branch from a5bc6a5 to 4aedb3b Compare January 20, 2025 12:06
@AtomicFS
Copy link
Collaborator Author

OK, NodeJS v16 it is. That is the newest we can use.

@AtomicFS AtomicFS requested a review from MDr164 January 20, 2025 12:07
@AtomicFS AtomicFS added this to the v0.11.0 relase milestone Jan 20, 2025
@AtomicFS AtomicFS added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit 23c8d31 Jan 20, 2025
103 checks passed
@AtomicFS AtomicFS deleted the fix/nodejs-for-udk2017 branch January 20, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDr164 MDr164 MDr164 approved these changes

Assignees
No one assigned
Labels
bugfix Bugfix / fix docker docker related module/edk2
Projects
None yet
Milestone
v0.11.0 relase
Development

Successfully merging this pull request may close these issues.

edk2 container udk2017 fails to build
2 participants
@AtomicFS @MDr164