ToPath: percent decode input URI #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful in cases where initial path contains special characters. For example, path containing "c++" needs to be properly decoded, otherwise Acme will try to open file containing %2B%2B, which is wrong. Issue 9fans#60 on GitHub.
|
This is particularly helpful when running LSPs in the context of Bazel-managed TypeScript code. |
fhs
reviewed
Oct 21, 2024
| @@ -127,6 +128,7 @@ func ToURI(filename string) protocol.DocumentURI { | |||
| // ToPath converts URI to filename. | |||
| func ToPath(uri protocol.DocumentURI) string { | |||
| filename, _ := CutPrefix(string(uri), "file://") | |||
| filename, _ = url.PathUnescape(filename) | |||
There was a problem hiding this comment.
Don't you still need to CutPrefix?
There was a problem hiding this comment.
I don't know, but I used this version with clangd I think, but I'm not sure about edge cases.
|
Whether it's required seems to depend on the language server. The Typescript language server seems to be happy without cutting the `file://` prefix off. It probably can't hurt to do both though, right?
…On Mon, Oct 21, 2024 at 06:50:08AM GMT, Fazlul Shahriar wrote:
@fhs commented on this pull request.
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
In internal/lsp/text/edit.go:
> @@ -127,6 +128,7 @@ func ToURI(filename string) protocol.DocumentURI {
// ToPath converts URI to filename.
func ToPath(uri protocol.DocumentURI) string {
filename, _ := CutPrefix(string(uri), "file://")
+ filename, _ = url.PathUnescape(filename)
Don't you still need to CutPrefix?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.*Message ID: <9fans/acme-lsp/pull/
***@***.***>
--
Gregor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful in cases where initial path contains special characters.
For example, path containing "c++" needs to be properly decoded, otherwise Acme will try to open file containing %2B%2B, which is wrong.
Partially fixes #60 on GitHub.