Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using outgoing channel id for onion messages #2762

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

thomash-acinq
Copy link
Member

Allow using a short channel id instead of a public key to designate the next node a message should be relayed to.

Allow using a short channel id instead of a public key to designate the next node a message should be relayed to.
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2023

Codecov Report

Merging #2762 (574aedf) into master (9ca9227) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is 97.61%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master    #2762   +/-   ##
=======================================
  Coverage   85.84%   85.84%           
=======================================
  Files         216      216           
  Lines       18102    18111    +9     
  Branches      762      740   -22     
=======================================
+ Hits        15540    15548    +8     
- Misses       2562     2563    +1     
Files Coverage Δ
...re/src/main/scala/fr/acinq/eclair/NodeParams.scala 93.39% <100.00%> (-0.03%) ⬇️
...ir-core/src/main/scala/fr/acinq/eclair/Setup.scala 75.14% <100.00%> (ø)
.../main/scala/fr/acinq/eclair/channel/Register.scala 88.57% <100.00%> (+0.33%) ⬆️
...-core/src/main/scala/fr/acinq/eclair/io/Peer.scala 87.71% <100.00%> (+0.10%) ⬆️
...rc/main/scala/fr/acinq/eclair/io/Switchboard.scala 85.71% <100.00%> (-0.50%) ⬇️
.../scala/fr/acinq/eclair/message/OnionMessages.scala 79.71% <100.00%> (+2.29%) ⬆️
...c/main/scala/fr/acinq/eclair/message/Postman.scala 95.65% <100.00%> (+0.06%) ⬆️
...cinq/eclair/remote/EclairInternalsSerializer.scala 97.82% <100.00%> (ø)
...scala/fr/acinq/eclair/router/BalanceEstimate.scala 98.93% <100.00%> (ø)
.../src/main/scala/fr/acinq/eclair/router/Graph.scala 97.25% <100.00%> (-0.09%) ⬇️
... and 6 more

... and 7 files with indirect coverage changes

@thomash-acinq thomash-acinq marked this pull request as ready for review October 5, 2023 09:26
@thomash-acinq thomash-acinq requested a review from t-bast October 5, 2023 09:26
Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me 👍

@thomash-acinq thomash-acinq merged commit ca3f681 into master Nov 2, 2023
@thomash-acinq thomash-acinq deleted the message-scid branch November 2, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants