Add closing test reconnect with 3rd-stage txs #2820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had some cases where channels were staying stuck in the CLOSING state without going to the CLOSED state in previous versions of eclair where we published different versions of our 3rd-stage transactions after a restart and a feerate increase. This happened in two cases: - when we published a different version of our claim-main, since we only store the latest (it's an `Option`, not a `Seq`) and put a watch on this specific `txid` instead of watching the corresponding output - when we re-published 3rd-stage txs after receiving `CMD_FULFILL_HTLC` because we replaced the previous `claim-htlc-delayed` transactions This was on my backlog for a while, and I wanted to take another look at it after the splicing implementation. Fortunately, this was fixed as part of the splicing changes, but it's worth having a test to ensure that there's no regression from future changes.
pm47
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some cases where channels were staying stuck in the CLOSING state without going to the CLOSED state in previous versions of eclair where we published different versions of our 3rd-stage transactions after a restart and a feerate increase.
This happened in two cases:
Option, not aSeq) and put a watch on this specifictxidinstead of watching the corresponding outputCMD_FULFILL_HTLCbecause we replaced the previousclaim-htlc-delayedtransactionsThis was on my backlog for a while, and I wanted to take another look at it after the splicing implementation. Fortunately, this was fixed as part of the splicing changes, but it's worth having a test to ensure that there's no regression from future changes.