Cancel splice early when missing funds #744
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we are splicing out or doing a CPFP on an existing splice, we use our channel balance to pay fees and the LSP doesn't contribute at all. We must have enough funds to pay the mining fees, otherwise we will go through all of the `interactive-tx` protocol but fail at the end when our peer will notice that we're not paying the feerate we said we would. We now fail early in that case, which also lets us provide a better error explaining why the splice attempt was cancelled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are splicing out or doing a CPFP on an existing splice, we use our channel balance to pay fees and the LSP doesn't contribute at all. We must have enough funds to pay the mining fees, otherwise we will go through all of the
interactive-txprotocol but fail at the end when our peer will notice that we're not paying the feerate we said we would.We now fail early in that case, which also lets us provide a better error explaining why the splice attempt was cancelled.