-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the user registration logic #107
Implement the user registration logic #107
Conversation
…d to check hashed pin with incoming pin
… specific data with it's hashed value
Fix(backend):removed UserRepository file
…n class to handle errors at runtime
Your code is not building. You should fix that @Awambeng @forkimenjeckayang @chendiblessing @mbunwe-victor please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work. You'll need to adjust these points
...src/main/java/com/adorsys/gis/powerpay/powerpaybackend/services/UserRegistrationService.java
Outdated
Show resolved
Hide resolved
...main/java/com/adorsys/gis/powerpay/powerpaybackend/services/UserRegistrationServiceImpl.java
Outdated
Show resolved
Hide resolved
…ository to manage the registration procedure
…l to use the UserRegistration repository file
…trationRepository
…matically generated an otp which will then be stored in the database
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better work already. But some points can still be refined:
...main/java/com/adorsys/gis/powerpay/powerpaybackend/services/UserRegistrationServiceImpl.java
Outdated
Show resolved
Hide resolved
...c/test/java/com/adorsys/gis/powerpay/powerpaybackend/utils_test/CompareHashPasswordTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
In this pr we implemented a method to create a user, generate an otp and hash its value and finally returned the procedure Id to the user upon creation.