Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reusable ScanList component for displaying previous scans #41

Conversation

bryandino673
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@Valsuh45 Valsuh45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

Copy link
Collaborator

@stephane-segning stephane-segning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change name to pascal case. E.g ScanView => scan-view

Copy link
Collaborator

@Ngha-Boris Ngha-Boris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bryandino673 can you consider adding error handling for cases where the data passed to the components is incomplete or malformed. For example, if avatarGroup or rawData is missing or invalid, you might want to handle these cases gracefully to prevent runtime errors.

@bryandino673 bryandino673 force-pushed the feature10/implementing-component-for-displaying-previous-scans branch from 2ec96e6 to b32f101 Compare May 2, 2024 08:36
@bryandino673 bryandino673 force-pushed the feature10/implementing-component-for-displaying-previous-scans branch from b32f101 to 5da1613 Compare May 2, 2024 08:38
@bryandino673 bryandino673 merged commit 88c2a4a into ADORSYS-GIS:main May 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants