-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reusable ScanList component for displaying previous scans #41
Add reusable ScanList component for displaying previous scans #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change name to pascal case. E.g ScanView
=> scan-view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @bryandino673 can you consider adding error handling for cases where the data passed to the components is incomplete or malformed. For example, if avatarGroup or rawData is missing or invalid, you might want to handle these cases gracefully to prevent runtime errors.
2ec96e6
to
b32f101
Compare
b32f101
to
5da1613
Compare
No description provided.