-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature #39 backend:Integrate analysis script with backend API #90
feature #39 backend:Integrate analysis script with backend API #90
Conversation
@stephane-segning feature(backend) integrate analysis script with backend API by @nancymuyeh & @Bansikah |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work guys! But still a problem, at least for me. This ticket is where you bind
as explained here #39. So normally you're not done yet, if those are not done. Plus, your code contains changes that are not coming from you. You probably didn't pulled changes from the main branch before adding your changes
@stephane-segning Removed files(global) removed files not needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You didn't reviewed my points. Please, cancel changes that are not related to your ticket.
ed433e6
to
27ff4b7
Compare
@stephane-segning [feature(backend) integrating analysis script with backend api correction |
06e23d7
to
ecfbb9e
Compare
This reverts commit ecfbb9e.
@stephane-segning resolved merge conflicts, There is a file in the branch test.ipynb please you it to test the code, i will delete after the code has been reviewed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! This is an example of good code! Well done @nancymuyeh @Bansikah
Thank you @stephane-segning |
No description provided.