Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature #39 backend:Integrate analysis script with backend API #90

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

nancymuyeh
Copy link
Collaborator

No description provided.

@nancymuyeh nancymuyeh linked an issue Nov 27, 2023 that may be closed by this pull request
@Bansikah
Copy link
Collaborator

@stephane-segning feature(backend) integrate analysis script with backend API by @nancymuyeh & @Bansikah

Copy link
Contributor

@stephane-segning stephane-segning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work guys! But still a problem, at least for me. This ticket is where you bind

as explained here #39. So normally you're not done yet, if those are not done. Plus, your code contains changes that are not coming from you. You probably didn't pulled changes from the main branch before adding your changes

templates/test.html Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
analysis.py Outdated Show resolved Hide resolved
analyze.ipynb Outdated Show resolved Hide resolved
doc/38-implement-data-analysis-script.md Outdated Show resolved Hide resolved
templates/base.html Outdated Show resolved Hide resolved
templates/results.html Outdated Show resolved Hide resolved
templates/input.html Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
@Bansikah
Copy link
Collaborator

@stephane-segning Removed files(global) removed files not needed

Copy link
Contributor

@stephane-segning stephane-segning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't reviewed my points. Please, cancel changes that are not related to your ticket.

.gitignore Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
templates/base.html Outdated Show resolved Hide resolved
templates/input.html Outdated Show resolved Hide resolved
templates/results.html Outdated Show resolved Hide resolved
templates/test.html Outdated Show resolved Hide resolved
@Bansikah Bansikah force-pushed the feature-39-integrate-analysis-script-with-backend-api branch from ed433e6 to 27ff4b7 Compare November 29, 2023 14:00
@Bansikah
Copy link
Collaborator

@stephane-segning [feature(backend) integrating analysis script with backend api correction
There is a file in the branch test.ipynb please you it to test the code, i will delete after the code has been reviewed

@Bansikah Bansikah force-pushed the feature-39-integrate-analysis-script-with-backend-api branch from 06e23d7 to ecfbb9e Compare November 30, 2023 12:26
@Bansikah
Copy link
Collaborator

Bansikah commented Nov 30, 2023

@stephane-segning resolved merge conflicts, There is a file in the branch test.ipynb please you it to test the code, i will delete after the code has been reviewed

Copy link
Contributor

@stephane-segning stephane-segning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! This is an example of good code! Well done @nancymuyeh @Bansikah

@Bansikah
Copy link
Collaborator

Thank you @stephane-segning

@Bansikah Bansikah merged commit 5290f6d into main Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Analysis Script with Backend API
4 participants