Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 35 integrate database storage with analysis script #97

Closed

Conversation

valsuh45
Copy link
Collaborator

implemented functionality to connect database to analyzed data

@valsuh45 valsuh45 linked an issue Nov 28, 2023 that may be closed by this pull request
@valsuh45
Copy link
Collaborator Author

hello @AssahBismarkabah @stephane-segning i created a pull request on relating the analyzed data to the database

@AssahBismarkabah
Copy link
Collaborator

AssahBismarkabah commented Nov 28, 2023 via email

Copy link
Contributor

@stephane-segning stephane-segning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot tell exactly what your changes are. So please explain it to me in the next meeting

app.py Outdated

app = Flask(__name__)
app.secret_key = 'your_secret_key' # Setting a secret key for flash messages
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this secret for?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this secret for?
Greetings @stephane-segning
Please Sir, concerning the above secret key, I've been trying to figure it out.
Wish to inform you that I and my team did not add any key to the app.py

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then remove it na

scraping.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this file? Is it related to your code?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this file? Is it related to your code?
Sir we later discovered that you asked the other teams to remove the scraping parameter, which was based on the images and the text. so we had to edit the scraping functionality without specifying the specific data to extract. as seen in the function below
def scrape_website(url, depth):

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this code should then change

app.py Outdated

app = Flask(__name__)
app.secret_key = 'your_secret_key' # Setting a secret key for flash messages
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then remove it na

scraping.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this code should then change

@valsuh45
Copy link
Collaborator Author

Ok Sir @stephane-segning
We are working on it

@AssahBismarkabah
Copy link
Collaborator

AssahBismarkabah commented Nov 30, 2023 via email

@valsuh45
Copy link
Collaborator Author

hello sir @stephane-segning we are done making the necessary changes in the app.py by importing the functions required for the database functionality

@AssahBismarkabah
Copy link
Collaborator

we also removed the

app = Flask(__name__)
app.secret_key = 'your_secret_key'  # 

which was not part of our work

@valsuh45 valsuh45 closed this Nov 30, 2023
@valsuh45 valsuh45 deleted the feature-35-integrate-database-storage-with-analysis-script branch November 30, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Database Storage with Analysis Script
3 participants