Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local api fix #91

Open
wants to merge 4 commits into
base: 3.0-devel
Choose a base branch
from
Open

Local api fix #91

wants to merge 4 commits into from

Conversation

EnricoMingo
Copy link
Contributor

This pull request add the possiblity to set local velocity references for Cartesian task.
While this was already possible using the topic by changing the frame_id entry of the message (as suggested by @alaurenzi), a method for the C++/Python API was missing.
This is now done through a flag which is also recognized by the cartesian tasks properties. The property is called use_local_velocity, it can be set through service, in the yaml file, or via C++/Python API. Is set to True, the frame_id is ignored when using the topic (maybe we can add a ROS info if needed)

@EnricoMingo EnricoMingo added the enhancement New feature or request label Sep 27, 2024
@EnricoMingo EnricoMingo self-assigned this Sep 27, 2024
@alaurenzi
Copy link
Contributor

Hi @EnricoMingo
I find it a bit confusing / error prone that a setter method works differently based on a flag that is set elsewhere (and not directly in the method's signature)

@EnricoMingo
Copy link
Contributor Author

Do you suggest putting these frag directly in the reference setters methods?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants