Custom Executor Example #2570
Open
Custom Executor Example #2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenukk
commented
Oct 1, 2024
| CrashFeedback::new(), | ||
| // We `and` the MaxMapFeedback to only end up with crashes that trigger new coverage. | ||
| // We use the _fast variant to make sure it's not evaluated every time, even if the crash didn't trigger.. | ||
| MaxMapFeedback::new(&observer) |
There was a problem hiding this comment.
How does this never trigger? Seems like a bug - or am I stupid?
Like, if I leave this guy out I get all crashes, if I have it I don't see single one.
I would assume I should get exactly one?
cc @tokatoka maybe?
There was a problem hiding this comment.
Name collision, ... should we add an atomic counter to names?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.