Remove ShMem associated type #2861
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmalmain
force-pushed
the
remove_shmem_associated_type
branch
from
5918b22 to
0b59600
Compare
tokatoka
reviewed
Jan 17, 2025
| @@ -84,6 +84,22 @@ pub trait X<A, B, C> // <- this trait have 3 generics, A, B, and C | |||
| fn do_other_stuff(&self, a: A, b: B); // <- this is not ideal because it does not have C. | |||
| } | |||
| ``` | |||
| - Generic naming should be consistent. Do NOT use multiple name for the same generic, it just makes things more confusing. Do | |||
There was a problem hiding this comment.
do you want to add?
"bounds in where clause should be ordered, too"
There was a problem hiding this comment.
in the appropriate place i mean. not here
There was a problem hiding this comment.
if others are ok with this i think it's better. wdyt @addisoncrump @domenukk ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
last step to remove most annoying associated types from libafl