Fix qemu cov #2875
Merged
Fix qemu cov #2875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenukk
reviewed
Jan 21, 2025
| _state: &mut S, | ||
| ) where | ||
| ET: EmulatorModuleTuple<I, S>, | ||
| { | ||
| emulator_modules.blocks( |
There was a problem hiding this comment.
Wouldn't it make sense / look nicer from an API side to have an extra method that gets called to set up hooks? It'd be called right before this one but have a name that's clearly for setup
There was a problem hiding this comment.
so, in that case, i guess what you want is to rename first_exec into fuzzing_setup or something similar?
some hooks can be set just after qemu gets initialized or just before the first fuzzing run, depending on the module. so i don't think we can just have a single method to set hooks up
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move DrCov hook initialization to
first_execto avoid using the hook before it's actually possible.