error handeling in libafl/src/corpus #2990
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i think most of these unwrap() will never happen. |
tokatoka
reviewed
Feb 15, 2025
tokatoka
reviewed
Feb 15, 2025
libafl/src/corpus/cached.rs
Outdated
| @@ -38,7 +38,9 @@ where | |||
| self.load_input_into(&mut testcase.borrow_mut())?; | |||
| let mut borrowed_num = 0; | |||
| while self.cached_indexes.borrow().len() >= self.cache_max_len { | |||
| let removed = self.cached_indexes.borrow_mut().pop_front().unwrap(); | |||
| let removed = self.cached_indexes.borrow_mut().pop_front().ok_or_else(|| { | |||
There was a problem hiding this comment.
this will never happen. the thing we really need is to make cache_max_len to NonZeroUsize
|
i don't know. the changes here are either correcting unwrap() that either
I perfer for the panic to stay because at least i can see the backtraces. |
|
Ok so i will can make some unwrap to be as it, and only chnage which are necessary |
|
see this this is what we really want then panic will never happen from this unwrap() will never happen |
domenukk
reviewed
Feb 17, 2025
libafl/src/corpus/inmemory.rs
Outdated
| if let Some(item) = self.map.remove(&id) { | ||
| self.remove_key(id); | ||
| if let Some(prev) = item.prev { | ||
| self.map.get_mut(&prev).unwrap().next = item.next; | ||
| self.map.get_mut(&prev).ok_or_else(|| Error::illegal_state("Unable to fetch previous CorpusId"))?.next = item.next; |
domenukk
reviewed
Feb 17, 2025
libafl/src/corpus/minimizer.rs
Outdated
| @@ -198,7 +198,7 @@ where | |||
| let mut removed = Vec::with_capacity(state.corpus().count()); | |||
| for (seed, (id, _)) in seed_exprs { | |||
| // if the model says the seed isn't there, mark it for deletion | |||
| if !model.eval(&seed, true).unwrap().as_bool().unwrap() { | |||
| if !model.eval(&seed, true).ok_or_else(|| Error::illegal_state("Error Evaluating Modal"))?.as_bool().ok_or_else(|| Error::illegal_state("Error converting condition to bool"))? { | |||
|
This also needs |
|
I have done cargo fmt, etc and now no errors are comming |
|
CI is still unhappy --> libafl/src/corpus/inmemory.rs:109:9
|
107 | pub fn remove(&mut self, id: CorpusId) -> Result<RefCell<Testcase<I>>, Error> {
| ----------------------------------- expected `Result<RefCell<Testcase<I>>, libafl_bolts::Error>` because of return type
108 | self.remove_key(id);
109 | self.map.remove(&id)
| ^^^^^^^^^^^^^^^^^^^^ expected `Result<RefCell<Testcase<I>>, Error>`, found `Option<RefCell<Testcase<I>>>`
| |
|
can you address my comment too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed all .unwrap with appropriate libafl_bolts::Error
#1908