Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restartable trait #3004

Merged
merged 8 commits into from
Feb 19, 2025
Merged

Restartable trait #3004

merged 8 commits into from
Feb 19, 2025

Conversation

tokatoka
Copy link
Member

Pull Request Checklist

Please make sure you've completed the following steps before submitting:

  • I have run ./script/fmt_all.sh to format the code
  • I have run ./script/clippy.sh and fixed all errors/warnings

@domenukk
Copy link
Member

domenukk commented Feb 19, 2025 •
edited
Loading

Looks good!
As mentioned in discord I would now add a perform_restartable function that takes Stage + Restartable and then does the right thing.

@domenukk
Copy link
Member

Sweet

@tokatoka tokatoka merged commit 61568a9 into main Feb 19, 2025
108 checks passed
@tokatoka tokatoka deleted the restartable branch February 19, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenukk domenukk domenukk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tokatoka @domenukk