Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xercesc parsing of environment variables in the xml path #1326

Merged
merged 5 commits into from
Oct 15, 2024

Conversation

dudarboh
Copy link
Contributor

@dudarboh dudarboh commented Sep 30, 2024

BEGINRELEASENOTES

ENDRELEASENOTES

See iLCSoft/Marlin#60 for the discussion.

This hard fixes it for me. But there is probably a cleaner way of doing it...
I am not an expert, so please cross-check.

Copy link

github-actions bot commented Oct 1, 2024

Test Results

   11 files     11 suites   5h 40m 41s ⏱️
  366 tests   165 ✅ 0 💤 201 ❌
1 506 runs  1 301 ✅ 0 💤 205 ❌

For more details on these failures, see this check.

Results for commit 5fe1774.

♻️ This comment has been updated with latest results.

@dudarboh
Copy link
Contributor Author

dudarboh commented Oct 1, 2024

I moved the function to the top of the file... Seems to work...

@andresailer andresailer changed the title Fix xercesc parsing of environment variables in the xml path Add xercesc parsing of environment variables in the xml path Oct 2, 2024
@andresailer
Copy link
Member

I just want to have @MarkusFrankATcernch comment on this, in case there is some side-effect from resolving environment variables here that could clash with other variables we resolve.

@MarkusFrankATcernch
Copy link
Contributor

Hmm..... This environment resolution mechanism is always a bit tricky and very often one runs into contradicting requirements.
Formally this all looks OK to me.
If all tests work I think this is fine. If people start to complain we can have a look at real use cases.

Copy link
Contributor

@MarkusFrankATcernch MarkusFrankATcernch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The environment resolution mechanism is always a bit tricky and very often one runs into contradicting requirements.
Formally this all looks OK to me.
If all tests work I think this is fine. If people start to complain we can have a look at real use cases.

@andresailer andresailer merged commit 6c11d77 into AIDASoft:master Oct 15, 2024
9 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants