-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xercesc parsing of environment variables in the xml path #1326
Conversation
Test Results 11 files 11 suites 5h 40m 41s ⏱️ For more details on these failures, see this check. Results for commit 5fe1774. ♻️ This comment has been updated with latest results. |
I moved the function to the top of the file... Seems to work... |
I just want to have @MarkusFrankATcernch comment on this, in case there is some side-effect from resolving environment variables here that could clash with other variables we resolve. |
Hmm..... This environment resolution mechanism is always a bit tricky and very often one runs into contradicting requirements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The environment resolution mechanism is always a bit tricky and very often one runs into contradicting requirements.
Formally this all looks OK to me.
If all tests work I think this is fine. If people start to complain we can have a look at real use cases.
BEGINRELEASENOTES
ENDRELEASENOTES
See iLCSoft/Marlin#60 for the discussion.
This hard fixes it for me. But there is probably a cleaner way of doing it...
I am not an expert, so please cross-check.