DataSource: implement missing GetLabel method (#682)

* GenericParameters: update comment * DataSource add missing GetLabel override * Make comment more generic Co-authored-by: Juan Miguel Carceller <[email protected]> --------- Co-authored-by: Juan Miguel Carceller <[email protected]>
AIDASoft · Sep 20, 2024 · c42a4ea · c42a4ea
1 parent 3e8f634
commit c42a4ea
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/include/podio/DataSource.h b/include/podio/DataSource.h
@@ -85,6 +85,10 @@ class DataSource : public ROOT::RDF::RDataSource {
   ///
   std::string GetTypeName(std::string_view columnName) const override;
 
+  std::string GetLabel() override {
+    return "PODIO Datasource";
+  };
+
 protected:
   ///
   /// @brief Type-erased vector of pointers to pointers to column

diff --git a/src/GenericParameters.cc b/src/GenericParameters.cc
@@ -17,7 +17,7 @@ GenericParameters::GenericParameters(const GenericParameters& other) :
     m_stringMtx(std::make_unique<std::mutex>()),
     m_doubleMtx(std::make_unique<std::mutex>()) {
   {
-    // acquire all three locks at once to make sure all three internal maps are
+    // acquire all locks at once to make sure all internal maps are
     // copied at the same "state" of the GenericParameters
     auto& intMtx = other.getMutex<int>();
     auto& floatMtx = other.getMutex<float>();