Use IWYU to add new headers

AIDASoft · Sep 8, 2024 · fa120f9 · fa120f9
1 parent 5618179
commit fa120f9
Show file tree

Hide file tree

Showing 79 changed files with 312 additions and 124 deletions.
diff --git a/.clang-format b/.clang-format
@@ -59,12 +59,12 @@ ForEachMacros:
   - foreach
   - Q_FOREACH
   - BOOST_FOREACH
-IncludeBlocks:   Preserve
+IncludeBlocks:   Regroup
 IncludeCategories:
-  - Regex:           '^(<|"(gtest|gmock|isl|json)/)'
-    Priority:        4
-  - Regex:           '.*'
-    Priority:        3
+  - Regex:           '<[[:alnum:]._]+>'
+    Priority:        5
+  - Regex:           '^(<"podio/)'
+    Priority:        1
 IncludeIsMainRegex: '(Test)?$'
 IndentCaseLabels: false
 IndentPPDirectives: BeforeHash

diff --git a/include/podio/CollectionBufferFactory.h b/include/podio/CollectionBufferFactory.h
@@ -6,6 +6,7 @@
 
 #include <functional>
 #include <optional>
+#include <string>
 #include <unordered_map>
 #include <vector>
 

diff --git a/include/podio/DatamodelRegistry.h b/include/podio/DatamodelRegistry.h
@@ -1,6 +1,7 @@
 #ifndef PODIO_DATAMODELREGISTRY_H
 #define PODIO_DATAMODELREGISTRY_H
 
+#include <stddef.h>
 #include <string>
 #include <string_view>
 #include <tuple>

diff --git a/include/podio/GenericParameters.h b/include/podio/GenericParameters.h
@@ -5,13 +5,18 @@
 #include "podio/utilities/TypeHelpers.h"
 
 #include <algorithm>
+#include <initializer_list>
 #include <iostream>
 #include <iterator>
 #include <map>
 #include <memory>
 #include <mutex>
 #include <optional>
+#include <stddef.h>
 #include <string>
+#include <tuple>
+#include <type_traits>
+#include <utility>
 #include <vector>
 
 #if PODIO_ENABLE_SIO

diff --git a/include/podio/RNTupleReader.h b/include/podio/RNTupleReader.h
@@ -1,23 +1,24 @@
 #ifndef PODIO_RNTUPLEREADER_H
 #define PODIO_RNTUPLEREADER_H
 
+#include "podio/GenericParameters.h"
 #include "podio/ROOTFrameData.h"
 #include "podio/SchemaEvolution.h"
 #include "podio/podioVersion.h"
 #include "podio/utilities/DatamodelRegistryIOHelpers.h"
+#include <ROOT/RVersion.hxx>
+#if ROOT_VERSION_CODE >= ROOT_VERSION(6, 31, 0)
+  #include <ROOT/RNTupleReader.hxx>
+#endif
 
+#include <memory>
 #include <string>
 #include <string_view>
 #include <unordered_map>
 #include <vector>
 
-#include <ROOT/RNTuple.hxx>
-#include <RVersion.h>
-#if ROOT_VERSION_CODE >= ROOT_VERSION(6, 31, 0)
-  #include <ROOT/RNTupleReader.hxx>
-#endif
-
 namespace podio {
+class CollectionIDTable;
 
 /**
 This class has the function to read available data from disk

diff --git a/include/podio/RNTupleWriter.h b/include/podio/RNTupleWriter.h
@@ -1,23 +1,33 @@
 #ifndef PODIO_RNTUPLEWRITER_H
 #define PODIO_RNTUPLEWRITER_H
 
-#include "podio/Frame.h"
+#include "TFile.h"
 #include "podio/SchemaEvolution.h"
 #include "podio/utilities/DatamodelRegistryIOHelpers.h"
 #include "podio/utilities/RootHelpers.h"
-
-#include "TFile.h"
-#include <ROOT/RNTuple.hxx>
 #include <ROOT/RNTupleModel.hxx>
+#include <ROOT/RVersion.hxx>
+
+#include <stdint.h>
+
+namespace ROOT {
+namespace Experimental {
+  class REntry;
+} // namespace Experimental
+} // namespace ROOT
 #if ROOT_VERSION_CODE >= ROOT_VERSION(6, 31, 0)
   #include <ROOT/RNTupleWriter.hxx>
 #endif
 
+#include <memory>
 #include <string>
+#include <tuple>
 #include <unordered_map>
 #include <vector>
 
 namespace podio {
+class Frame;
+class GenericParameters;
 
 /// The RNTupleWriter writes podio files into ROOT files using the new RNTuple
 /// format.

diff --git a/include/podio/ROOTFrameData.h b/include/podio/ROOTFrameData.h
@@ -9,6 +9,7 @@
 #include <optional>
 #include <string>
 #include <unordered_map>
+#include <vector>
 
 namespace podio {
 

diff --git a/include/podio/ROOTLegacyReader.h b/include/podio/ROOTLegacyReader.h
@@ -1,12 +1,11 @@
 #ifndef PODIO_ROOTLEGACYREADER_H
 #define PODIO_ROOTLEGACYREADER_H
 
+#include "TChain.h"
 #include "podio/ROOTFrameData.h"
 #include "podio/podioVersion.h"
 #include "podio/utilities/RootHelpers.h"
 
-#include "TChain.h"
-
 #include <memory>
 #include <string>
 #include <tuple>

diff --git a/include/podio/ROOTReader.h b/include/podio/ROOTReader.h
@@ -1,25 +1,22 @@
 #ifndef PODIO_ROOTREADER_H
 #define PODIO_ROOTREADER_H
 
+#include "TChain.h"
 #include "podio/ROOTFrameData.h"
+#include "podio/SchemaEvolution.h"
 #include "podio/podioVersion.h"
 #include "podio/utilities/DatamodelRegistryIOHelpers.h"
 #include "podio/utilities/RootHelpers.h"
 
-#include "TChain.h"
-
 #include <memory>
+#include <stddef.h>
 #include <string>
 #include <string_view>
 #include <tuple>
+#include <unordered_map>
 #include <utility>
 #include <vector>
 
-// forward declarations
-class TClass;
-class TFile;
-class TTree;
-
 namespace podio {
 
 namespace detail {
@@ -30,7 +27,6 @@ namespace detail {
 
 } // namespace detail
 
-class CollectionBase;
 class CollectionIDTable;
 class GenericParameters;
 struct CollectionReadBuffers;

diff --git a/include/podio/ROOTWriter.h b/include/podio/ROOTWriter.h
@@ -1,12 +1,11 @@
 #ifndef PODIO_ROOTWRITER_H
 #define PODIO_ROOTWRITER_H
 
+#include "TFile.h"
 #include "podio/CollectionIDTable.h"
 #include "podio/utilities/DatamodelRegistryIOHelpers.h"
 #include "podio/utilities/RootHelpers.h"
 
-#include "TFile.h"
-
 #include <memory>
 #include <string>
 #include <tuple>
@@ -18,7 +17,6 @@ class TTree;
 
 namespace podio {
 class Frame;
-class CollectionBase;
 class GenericParameters;
 
 /// The ROOTWriter writes podio files into ROOT files using TTrees.

diff --git a/include/podio/Reader.h b/include/podio/Reader.h
@@ -2,8 +2,16 @@
 #define PODIO_READER_H
 
 #include "podio/Frame.h"
+#include "podio/FrameCategories.h"
 #include "podio/podioVersion.h"
 
+#include <memory>
+#include <cstddef>
+#include <stdexcept>
+#include <string>
+#include <string_view>
+#include <vector>
+
 namespace podio {
 
 /// Generic (type erased) reader class that can handle different I/O backends

diff --git a/include/podio/SIOBlock.h b/include/podio/SIOBlock.h
@@ -6,7 +6,6 @@
 #include <podio/GenericParameters.h>
 #include <podio/podioVersion.h>
 #include <podio/utilities/TypeHelpers.h>
-
 #include <sio/block.h>
 #include <sio/io_device.h>
 #include <sio/version.h>

diff --git a/include/podio/SIOBlockUserData.h b/include/podio/SIOBlockUserData.h
@@ -5,7 +5,6 @@
 #include "podio/CollectionBuffers.h"
 #include "podio/SIOBlock.h"
 #include "podio/UserDataCollection.h"
-
 #include <sio/api.h>
 #include <sio/io_device.h>
 #include <sio/version.h>

diff --git a/include/podio/SIOFrameData.h b/include/podio/SIOFrameData.h
@@ -5,7 +5,6 @@
 #include "podio/CollectionIDTable.h"
 #include "podio/GenericParameters.h"
 #include "podio/SIOBlock.h"
-
 #include <sio/buffer.h>
 #include <sio/definitions.h>
 

diff --git a/include/podio/SIOLegacyReader.h b/include/podio/SIOLegacyReader.h
@@ -4,7 +4,6 @@
 #include "podio/SIOBlock.h"
 #include "podio/SIOFrameData.h"
 #include "podio/podioVersion.h"
-
 #include <sio/definitions.h>
 
 #include <memory>

diff --git a/include/podio/SIOReader.h b/include/podio/SIOReader.h
@@ -5,7 +5,6 @@
 #include "podio/SIOFrameData.h"
 #include "podio/podioVersion.h"
 #include "podio/utilities/DatamodelRegistryIOHelpers.h"
-
 #include <sio/definitions.h>
 
 #include <memory>

diff --git a/include/podio/SIOWriter.h b/include/podio/SIOWriter.h
@@ -3,7 +3,6 @@
 
 #include "podio/SIOBlock.h"
 #include "podio/utilities/DatamodelRegistryIOHelpers.h"
-
 #include <sio/definitions.h>
 
 #include <string>

diff --git a/include/podio/SchemaEvolution.h b/include/podio/SchemaEvolution.h
@@ -3,6 +3,7 @@
 
 #include <cstdint>
 #include <functional>
+#include <stddef.h>
 #include <string>
 #include <unordered_map>
 #include <vector>

diff --git a/include/podio/UserDataCollection.h b/include/podio/UserDataCollection.h
@@ -7,6 +7,18 @@
 #include "podio/SchemaEvolution.h"
 #include "podio/utilities/TypeHelpers.h"
 
+#include <iostream>
+#include <stddef.h>
+#include <stdint.h>
+#include <string_view>
+#include <tuple>
+#include <type_traits>
+#include <vector>
+
+namespace podio {
+class ICollectionProvider;
+} // namespace podio
+
 #define PODIO_ADD_USER_TYPE(type)                                                                                      \
   template <>                                                                                                          \
   constexpr const char* userDataTypeName<type>() {                                                                     \

diff --git a/include/podio/Writer.h b/include/podio/Writer.h
@@ -2,6 +2,11 @@
 #define PODIO_WRITER_H
 
 #include "podio/Frame.h"
+#include "podio/FrameCategories.h"
+
+#include <memory>
+#include <string>
+#include <vector>
 
 namespace podio {
 

diff --git a/include/podio/utilities/DatamodelRegistryIOHelpers.h b/include/podio/utilities/DatamodelRegistryIOHelpers.h
@@ -1,15 +1,16 @@
 #ifndef PODIO_UTILITIES_DATAMODELREGISTRYIOHELPERS_H
 #define PODIO_UTILITIES_DATAMODELREGISTRYIOHELPERS_H
 
-#include "podio/CollectionBase.h"
-#include "podio/DatamodelRegistry.h"
-
 #include <set>
+#include <stddef.h>
 #include <string>
+#include <string_view>
 #include <tuple>
+#include <utility>
 #include <vector>
 
 namespace podio {
+class CollectionBase;
 
 /// Helper class to collect the datamodel (JSON) definitions that should be
 /// written.

diff --git a/include/podio/utilities/RootHelpers.h b/include/podio/utilities/RootHelpers.h
@@ -3,13 +3,19 @@
 
 #include "podio/GenericParameters.h"
 
-#include "ROOT/RVec.hxx"
-#include "TBranch.h"
-
+#include <stdint.h>
 #include <string>
 #include <tuple>
 #include <vector>
 
+class TBranch;
+namespace ROOT {
+namespace VecOps {
+  template <typename T>
+  class RVec;
+} // namespace VecOps
+} // namespace ROOT
+
 namespace podio {
 class CollectionBase;
 

diff --git a/src/CollectionBufferFactory.cc b/src/CollectionBufferFactory.cc
@@ -1,6 +1,10 @@
 #include "podio/CollectionBufferFactory.h"
+
 #include "podio/CollectionBuffers.h"
 
+#include <stddef.h>
+#include <utility>
+
 namespace podio {
 CollectionBufferFactory& CollectionBufferFactory::mutInstance() {
   static CollectionBufferFactory factory;

diff --git a/src/CollectionIDTable.cc b/src/CollectionIDTable.cc
@@ -5,6 +5,9 @@
 
 #include <algorithm>
 #include <iostream>
+#include <iterator>
+#include <stddef.h>
+#include <utility>
 
 namespace podio {
 

diff --git a/src/DataSource.cc b/src/DataSource.cc
@@ -1,4 +1,5 @@
 #include "podio/DataSource.h"
+
 #include "podio/Reader.h"
 
 // podio

diff --git a/src/DatamodelRegistryIOHelpers.cc b/src/DatamodelRegistryIOHelpers.cc
@@ -1,5 +1,10 @@
 #include "podio/utilities/DatamodelRegistryIOHelpers.h"
+
+#include "podio/CollectionBase.h"
+#include "podio/DatamodelRegistry.h"
+
 #include <algorithm>
+#include <iostream>
 #include <iterator>
 
 namespace podio {