Make it possible to dispose of unconsumed collection buffers #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
changed the title
tmadlener
force-pushed
the
fix-mem-leak-buffers
branch
from
9f8aaa0
to
e0c71cf
Compare
|
This should fix #500 (still have to test that on a larger scale) but it is a bit cumbersome and the "proper" solution would be to make the I would be happy to merge this as is to fix the current leak and then address the "proper" solution after v1.0, because I am not entirely sure whether it can be made to work with the EventStore. |
tmadlener
force-pushed
the
fix-mem-leak-buffers
branch
from
e0c71cf
to
1d877f7
Compare
|
Is it WIP or are you finished with this now? I am asking because of more commits coming in. Thanks |
|
Just finished a few more larger scale tests and valgrind and this fixes the leaks of unconsumed collection buffers. |
hegner
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
deleteBuffersfunction that is populated at generation time to theCollectionReadBuffersto make it possible to dispose of unconsumed buffers. This fixes the main leaks described in ROOTFrameData leaks collection buffers that are not requested by the Frame #500ROOTFrameDataclean up all unconsumed buffers at desctruction.ENDRELEASENOTES
Fixes #500