Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure test environment points to the correct place #687

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

tmadlener
Copy link
Collaborator

BEGINRELEASENOTES

  • Make sure the ROOT_INCLUDE_PATH in the test environment points to the correct place.

ENDRELEASENOTES

Should point into the source tree not the build tree (where the pointed to place does not exist).

Copy link
Collaborator

@hegner hegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tests run through, I'll merge. thanks!

@tmadlener
Copy link
Collaborator Author

tmadlener commented Sep 23, 2024

The key4hep based one will likely fail: key4hep/key4hep-spack#651

edit: Looks like pre-commit also doesn't fully work

@hegner
Copy link
Collaborator

hegner commented Sep 23, 2024

The pre-commit looks very strange, but unrelated to this change. Key4hep worked though

@hegner hegner merged commit 0fa08d8 into AIDASoft:master Sep 23, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants