Defer numpy import on first pass of setup.py #761
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #653 by ensuring that
numpy
is not required on the first pass ofsetup.py
. This makespyradiomics
easy to install into new virtual environments without having an a priori installation of numpy.The update is based on the fact that setuptools invokes
setup.py
multiple times, and on the first pass, you must guard import statements of modules in thesetup_requires
section. We can therefore mock out thenumpy
module on the first pass, which should not affect the subsequent installation steps after the build system has fetched numpy and installed it.