Disable CvodeF checkpointing #2645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amici wants to avoid sundials' checkpointing, that's we set `steps` (the number of integration steps at which a checkpoint is created) for `CVodeAdjInit` to the maximum number of integration steps (`mxsteps`) for the forward problem. However, the checkpoint is created at step `steps`, not at step `steps + 1`. Therefore, if the forward integration takes exactly `mxsteps`, a checkpoint is still created. This is not a problem per se, but it may trigger segfaults under circumstances not fully understood (-> LLNL/sundials#49). Although unlikely, it still occasionally crashes long running optimizations. This change should make sure that checkpointing never occurs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2645 +/- ##
========================================
Coverage 77.17% 77.17%
========================================
Files 332 332
Lines 23139 23139
Branches 1478 1478
========================================
Hits 17857 17857
Misses 5271 5271
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Although I don't quite understand the details, LLNL/sundials#49 Basically, the segfault occurs if the forward integration during the backward pass (CVodeB->CVode) takes more steps than the forward integration during the forward pass (CVodeF->CVode). |
FFroehlich
approved these changes
Feb 17, 2025
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Feb 18, 2025
amici wants to avoid sundials' checkpointing, that's we set `steps` (the number of integration steps at which a checkpoint is created) for `CVodeAdjInit` to the maximum number of integration steps (`mxsteps`) for the forward problem. However, the checkpoint is created at step `steps`, not at step `steps + 1`. Therefore, if the forward integration takes exactly `mxsteps`, a checkpoint is still created. This is not a problem per se, but it may trigger segfaults under circumstances not fully understood (-> LLNL/sundials#49). Although unlikely, it still occasionally crashes long running optimizations. This change should make sure that checkpointing never occurs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amici wants to avoid sundials' checkpointing, that's why we set
steps(the number of integration steps at which a checkpoint is created) forCVodeAdjInitto the maximum number of integration steps (mxsteps) for the forward problem.However, the checkpoint is created at step
steps, not at stepsteps + 1.Therefore, if the forward integration takes exactly
mxsteps, a checkpoint is still created.This is not a problem per se, but it may trigger segfaults under circumstances not fully understood (-> LLNL/sundials#49). Although unlikely, it still occasionally crashes long running optimizations.
This change should make sure that checkpointing never occurs.