Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle relational operators in SBML import #2652

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Mar 4, 2025

Fixes #2651.

Related to #2146

@dweindl dweindl requested a review from a team as a code owner March 4, 2025 08:12
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.16%. Comparing base (f742e48) to head (9673abd).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2652      +/-   ##
===========================================
- Coverage    77.19%   77.16%   -0.04%     
===========================================
  Files          332      332              
  Lines        23142    23142              
  Branches      1480     1480              
===========================================
- Hits         17864    17857       -7     
- Misses        5267     5274       +7     
  Partials        11       11              
Flag Coverage Δ
cpp 74.09% <ø> (-0.04%) ⬇️
cpp_python 33.38% <ø> (ø)
petab 39.40% <ø> (ø)
python 72.21% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/import_utils.py 89.36% <ø> (ø)

... and 2 files with indirect coverage changes

@dweindl dweindl added this pull request to the merge queue Mar 4, 2025
Merged via the queue into AMICI-dev:develop with commit 591173d Mar 4, 2025
25 of 26 checks passed
@dweindl dweindl deleted the fix_2651 branch March 4, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants